IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
testing wavpack (4.70.0), especially with regard to transcoding, found some possible bugs?
azaqiel
post Mar 18 2013, 04:06
Post #1





Group: Members
Posts: 25
Joined: 4-January 13
Member No.: 105572



I compiled r295 of WavPack, on 64-bit Windows. I used pretty much vanilla Visual C++ 2010 Express on Windows 8 (just got this machine March 8). I used the included solution from Visual Studio 9, which was automatically converted. the first problem was my system was lacking afxres.h (included in wavpackdll.rc). fixed that by changing:
CODE
#include "afxres.h"
to
CODE
#include <windows.h>

of more importance to (some) end-users, the transcoding feature is less than working, and the documentation on this lacks.

here's the command line used:
CODE
>"wavpack\wavpack.exe" -hh -i -m -x6 "Z:\audio\wavpack\cake; b-sides and rarities\01 war pigs.wv" "C:\Users\Christopher\Music\wavpack\cake; b-sides and rarities\01 war pigs.wv"

the error was:
CODE
illegal option: h !
illegal option: h !
illegal option: 6 !

I know, transcoding wavpack to wavpack is probably pointless. I just got bored. laugh.gif
also, this transcode was not hybrid to lossless; just plain lossless to lossless.
Go to the top of the page
+Quote Post
bryant
post Mar 18 2013, 07:41
Post #2


WavPack Developer


Group: Developer (Donating)
Posts: 1292
Joined: 3-January 02
From: San Francisco CA
Member No.: 900



I certainly can't explain the errors you're getting because it doesn't look like you even get past parsing the command-line...it certainly doesn't have anything to do with the new transcoding feature. Does your compiled version do anything right?

In any event, the transcoding feature is less than a week old (which explains the lack of documentation) and I haven't even tried compiling it for Windows myself (I do my development on Linux). I should get to that in the next week or so, and maybe I'll figure out what's going on.

As for the transcoding feature, it is only for transcoding WavPack to WavPack, and once it's working (well, it's working great on Linux) it should be very handy because it uses temp files (so it can work safely "in-place") and copies all the tags over (and even supports adding/deleting/chaging the tags).

David


Go to the top of the page
+Quote Post
GenjuroXL
post Mar 18 2013, 09:29
Post #3





Group: Members
Posts: 46
Joined: 8-May 02
Member No.: 1998



I've just tried building the latest SVN in MingW-w64 and everything seems to be working, except for an error when trying to build the manual (the .1 files appear to be missing).
I ran some preliminary tests with the resulting wavpack binary and it seems to work, at least the files it produces bit-compare fine against 4.60.1 encodes (using the official win32 binary).

Edit: Forgot to mention that there are no problems parsing the commandline options either, so that might be a problem with the MSVC project files or MSVC itself?

If anyone else wants to test, I've uploaded the binaries here: http://negju.musepack.net/wavpack-SVN-win64.7z

This post has been edited by GenjuroXL: Mar 18 2013, 09:33
Go to the top of the page
+Quote Post
azaqiel
post Mar 18 2013, 14:40
Post #4





Group: Members
Posts: 25
Joined: 4-January 13
Member No.: 105572



the binary encodes wav to wavpack just fine, but not wavpack to wavpack.

EDIT: just tried GenjuroXL's build, it does transcode. must just be MSVC, or maybe because my system lacks the "afxres.h" file. I have no idea what that's even for...

EDIT 2: forgot to mention that I've been using the exact same arguments each time. for wav to wavpack and wavpack to wavpack.

This post has been edited by azaqiel: Mar 18 2013, 14:57
Go to the top of the page
+Quote Post
azaqiel
post Mar 18 2013, 16:34
Post #5





Group: Members
Posts: 25
Joined: 4-January 13
Member No.: 105572



I apologize, Mr. Bryant. it seems my above bug report is invalid. transcoding works. operator error.

however, there are still two (actually reproducible) problems.

wavpackdll.dll still doesn't compile. apparently, the entire point of "afxres.h" (which was still not found after I installed Microsoft Windows SDK) is to include <windows.h>. so my substitution in the first post makes sense...
lastly, with regard to the new temp file feature:
CODE
>"C:\Users\Christopher\Desktop\multimedia\utils\wavpack debug\wavpack.exe" -d -hh -i -m -x6 -y "C:\Users\Christopher\Desktop\multimedia\encodes\wavpack\soul coughing; studio b-sides\*.wv"

WAVPACK  Hybrid Lossless Audio Compressor  Win32 Version 4.70.0-alpha
Copyright (c) 1998 - 2013 Conifer Software.  All Rights Reserved.

can not rename temp file C:\Users\Christopher\Desktop\multimedia\encodes\wavpack\soul coughing; studio b-sides\04 the brooklynites.tmp.wv to C:\Users\Christopher\Desktop\multimedia\encodes\wavpack\soul coughing; studio b-sides\04 the brooklynites.wv!
there was only one file in the folder (04 the brooklynites.wv), which is why there is only one error.

This post has been edited by azaqiel: Mar 18 2013, 16:54
Go to the top of the page
+Quote Post
Mr_Rabid_Teddybe...
post Mar 18 2013, 22:59
Post #6





Group: Members
Posts: 1197
Joined: 3-September 03
From: Bergen, Norway
Member No.: 8667



QUOTE (GenjuroXL @ Mar 18 2013, 01:29) *
I've just tried building the latest SVN in MingW-w64 and everything seems to be working, except for an error when trying to build the manual (the .1 files appear to be missing).


The manpage *.1 files are buildt from the *.xml files in man directory and buildt for me after installing packages docbook, docbook-xml and docbook-xsl on Debian. Probably not all of them required, maybe only docbook-xsl, I don't know....?

I guess you could try --disable-man to configure to silence errors if that works...? (I have no experience with MinGW.)


EDIT: Typo.



This post has been edited by Mr_Rabid_Teddybear: Mar 18 2013, 23:07


--------------------
"ONLY THOSE WHO ATTEMPT THE IMPOSSIBLE WILL ACHIEVE THE ABSURD"
- Oceania Association of Autonomous Astronauts
Go to the top of the page
+Quote Post
kode54
post Mar 18 2013, 23:46
Post #7





Group: Admin
Posts: 4664
Joined: 15-December 02
Member No.: 4082



QUOTE (azaqiel @ Mar 18 2013, 08:34) *
wavpackdll.dll still doesn't compile. apparently, the entire point of "afxres.h" (which was still not found after I installed Microsoft Windows SDK) is to include <windows.h>.

MSVC resource compiler probably defines all of that internally, as the only place I can find an afxres.h is with MinGW, which only serves to include windows.h and define IDC_STATIC to -1.
Go to the top of the page
+Quote Post
azaqiel
post Mar 19 2013, 17:33
Post #8





Group: Members
Posts: 25
Joined: 4-January 13
Member No.: 105572



QUOTE (kode54 @ Mar 18 2013, 17:46) *
MSVC resource compiler probably defines all of that internally
actually, I tried commenting out the #include "afxres.h" first, and the dll didn't compile at all (a bunch of errors), which is why I changed it to #include <windows.h>.

I think I read that trick somewhere on msdn's social something-or-other.
Go to the top of the page
+Quote Post
bryant
post Mar 20 2013, 04:06
Post #9


WavPack Developer


Group: Developer (Donating)
Posts: 1292
Joined: 3-January 02
From: San Francisco CA
Member No.: 900



Thanks for the bug reports!

I am not very concerned about the DLL build problem because none of the supplied programs or plugins use it (it's basically for 3rd party developers) and I'm sure I'll figure it out once I try to build it (with VS 2008).

The rename issue is simply that the win32 rename() function will fail if the target already exists whereas on Linux rename() does an atomic delete and rename in that case (which is obviously what I want). For Windows I'll have to use another solution, but I'll attend to that once I move over to Windows.

David

Go to the top of the page
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 27th November 2014 - 15:21