IPB

Welcome Guest ( Log In | Register )

> foobar2000 Tech Support Forum Rules

Please read foobar2000 Tech Support Forum Rules before posting and comply with all the points.
Failure to provide all the information pointed out in the above document in your post is considered wasting other people's time and in extreme cases will lead to your topic getting locked without a reply.


See also: Hydrogenaudio Terms of Service.

 
Reply to this topicStart new topic
Crash in foo_input_std, via Verify Integrity
lvqcl
post Feb 28 2013, 16:31
Post #1





Group: Developer
Posts: 3414
Joined: 2-December 07
Member No.: 49183



Take a WAV file in WAVE_FORMAT_EXTENSIBLE format with wValidBitsPerSample == 20 and wBitsPerSample == 24.
Compress it to FLAC or Wavpack (cmdline encoders).

fb2k cannot verify integrity of such files: it crashes. No problems with the original WAV file though.

This post has been edited by lvqcl: Feb 28 2013, 16:31
Go to the top of the page
+Quote Post
Peter
post Mar 5 2013, 14:59
Post #2


foobar2000 developer


Group: Admin
Posts: 3293
Joined: 30-September 01
Member No.: 84



This is most interesting, thanks for the report.
Go to the top of the page
+Quote Post
lvqcl
post Mar 14 2013, 17:58
Post #3





Group: Developer
Posts: 3414
Joined: 2-December 07
Member No.: 49183



On the other hand, fb2k doesn't crash if wBitsPerSample == 24 and wValidBitsPerSample == 16.

AND: FLAC calculates MD5 of such files differently than WavPack, TAK and OFR. (I wrote about it: http://www.hydrogenaudio.org/forums/index....st&p=827385 )
Go to the top of the page
+Quote Post
lvqcl
post Mar 18 2013, 16:19
Post #4





Group: Developer
Posts: 3414
Joined: 2-December 07
Member No.: 49183



I took Garbage sample from this thread and converted it to 3-bit pcm so it's possible to test various BitsPerSample / ValidBitsPerSample combinations: Attached File  wValidBitsPerSample.7z ( 585.98K ) Number of downloads: 60


fb2k 1.2.4 b1 doesn't crash but it doesn't cover some exotic cases (the result is MD5 mismatch for WavPack and Unsupported format or corrupted file for FLAC)
Go to the top of the page
+Quote Post
Peter
post Mar 22 2013, 14:44
Post #5


foobar2000 developer


Group: Admin
Posts: 3293
Joined: 30-September 01
Member No.: 84



Thanks for the detailed report.

FLAC with bit depth below 8 = fixed for the next update after 1.2.4 beta 3.
Exotic cases of WavPack bit depth configs (with 8 or more bits wasted) currently fail checksumming, I'll need to add special handling for these.
Go to the top of the page
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 25th October 2014 - 18:52