Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: TAudioConverter (Read 315668 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

TAudioConverter

Reply #600
Feedback for latest beta:

- With passing trimming values (what's that anyway) disabled, the conversion result doesn't change the MD5 audio checksum, as expected.
Code: [Select]
Item: "\\server\input\\01 →unfinished→.flac"
MD5: C8E8635B95E3C9208969994C6673CE5F
CRC32: 5292F284
No problems found.

Item: "R:\output\01 →unfinished→_1.flac"
MD5: C8E8635B95E3C9208969994C6673CE5F
CRC32: 5292F284
No problems found.

Item: "\\server\input\\02 Sakura no Ame mo Egi no yo.flac"
MD5: 22FF8FCFC559CFA6C35BB3475530D800
CRC32: 952661F3
No problems found.

Item: "R:\output\02 Sakura no Ame mo Egi no yo_1.flac"
MD5: 22FF8FCFC559CFA6C35BB3475530D800
CRC32: 952661F3
No problems found.

Item: "\\server\input\\03 →unfinished→ -instrumental-.flac"
MD5: D08DFACCA31E4693FF9B15A1EC3C64DC
CRC32: BC24776B
No problems found.

Item: "R:\output\03 →unfinished→ -instrumental-_1.flac"
MD5: D08DFACCA31E4693FF9B15A1EC3C64DC
CRC32: BC24776B
No problems found.

Item: "\\server\input\\04 Sakura no Ame mo Egi no yo -instrumental-.flac"
MD5: 0B7F879FAF038FCF95DC423D89A5EE0D
CRC32: 0FC34617
No problems found.

Item: "R:\output\04 Sakura no Ame mo Egi no yo -instrumental-_1.flac"
MD5: 0B7F879FAF038FCF95DC423D89A5EE0D
CRC32: 0FC34617
No problems found.


All items decoded successfully.

- With passing trimming values enabled, the conversion result is NOT lossless, BUT! CUETools still says the rip is accurate!  (It does say "Padded some input files to a frame boundary", though.
Code: [Select]
Item: "R:\output\01 →unfinished→.flac"
MD5: C8E8635B95E3C9208969994C6673CE5F
CRC32: 5292F284
No problems found.

Item: "\\server\input\\01 →unfinished→.flac"
MD5: C8E8635B95E3C9208969994C6673CE5F
CRC32: 5292F284
No problems found.

Item: "R:\output\02 Sakura no Ame mo Egi no yo.flac"
MD5: CE2261214D6448C853917F92240C518A
CRC32: 1641AB47
No problems found.

Item: "\\server\input\\02 Sakura no Ame mo Egi no yo.flac"
MD5: 22FF8FCFC559CFA6C35BB3475530D800
CRC32: 952661F3
No problems found.

Item: "R:\output\03 →unfinished→ -instrumental-.flac"
MD5: 83CA52C2BD8B2584B8B0F217611B3EF5
CRC32: 2F0D1F43
No problems found.

Item: "\\server\input\\03 →unfinished→ -instrumental-.flac"
MD5: D08DFACCA31E4693FF9B15A1EC3C64DC
CRC32: BC24776B
No problems found.

Item: "R:\output\04 Sakura no Ame mo Egi no yo -instrumental-.flac"
MD5: 0B7F879FAF038FCF95DC423D89A5EE0D
CRC32: 0FC34617
No problems found.

Item: "\\server\input\\04 Sakura no Ame mo Egi no yo -instrumental-.flac"
MD5: 0B7F879FAF038FCF95DC423D89A5EE0D
CRC32: 0FC34617
No problems found.


All items decoded successfully.

- all in all, I don't think you should pass trimming values per default, as changing the audio md5 sum appears to be a critical encoding error at first glance.
- tagging with TTagger makes CUETools choke on non-ASCII filenames with a "cannot retrieve metadata" error message, so I disabled that.
- .tak album art embedding still doesn't work
- copying replaygain files when output lossless works as expected as well

TAudioConverter

Reply #601
OK, from now on trimming will be used iff user modifies start-end values, I've made that change now and it works well. I'm working on artwork in ape tags.

TAudioConverter

Reply #602
Hi ozok!

I wish for an option to automatically clear the list og songs/elements after a 100% successful conversion. Would save me for much time when converting lots of stuff.

TAudioConverter

Reply #603
Hi ozok!

I wish for an option to automatically clear the list og songs/elements after a 100% successful conversion. Would save me for much time when converting lots of stuff.

This will be availabe in the next release.

TAudioConverter

Reply #604
Could you add the ability to add custom file output name, without having to enable "custom folder tree"? Would be very useful.

 

TAudioConverter

Reply #605
Could you add the ability to add custom file output name, without having to enable "custom folder tree"? Would be very useful.


I don't understand what you ask. An option like "Full folder tree" combined with custom file name?

TAudioConverter

Reply #606
Could you add the ability to add custom file output name, without having to enable "custom folder tree"? Would be very useful.


I don't understand what you ask. An option like "Full folder tree" combined with custom file name?


Custom file name alone. I don't want custom folder tree, just custom output name. It does not seem i can enable custom output name without folder tree.


TAudioConverter

Reply #608
I'm working on artwork in ape tags.
Any update on this? :3
I'm assuming this will bring album art tags for tak, wv, mpc and ape itself?

Also, a request for another mode for creating a directory structure. From what I see currently if you have your music in say, C:\source\path\music\artist\albumA, albumB etc, add the music folder and set output to D:\dest\path\music, the resulting paths will be either

- D:\dest\path\music\source\path\music\artist\albumA, albumB etc
- D:\dest\path\music\albumA, albumB etc
- D:\dest\path\music\all music files

Can we please also have the following:
- D:\dest\path\music\artist\albumA, albumB

Basically, only replicate the folder structure starting from the input folder, not from the start of the path

edit: Also, I don't know why, but I'm getting a lot of md5 audio sum mismatches on some, but not all files I'll pm you the link to samples when they finish uploading. Btw, the source files from those albums report as "correct" rip, while the converted one are reported as "not a correct gapless rip" - trimming is not enabled.

suggestion: why not use the corresponding decoding features of lossless formats to decode to wav instead of ffmpeg? Who knows what it might be discarding upon extraction. And since you already package them to be able to encode, why not?

TAudioConverter

Reply #609
Quote
...
Any update on this? :3
I'm assuming this will bring album art tags for tak, wv, mpc and ape itself?

Yes this is the main reason why I'm trying to write a tagging tool myself.
I don't remember if I said this before but, at the moment I can write cover art to ape files but no player so far managed to show them. Image stream is definitely copied to ape file and foobar2000 and other software players play the file fine.
Quote
Also, a request for another mode for creating a directory structure. From what I see currently if you have your music in say, C:\source\path\music\artist\albumA, albumB etc, add the music folder and set output to D:\dest\path\music, the resulting paths will be either
...
Basically, only replicate the folder structure starting from the input folder, not from the start of the path

I was actually planning to add some sort of folder level selection.
Quote
edit: Also, I don't know why, but I'm getting a lot of md5 audio sum mismatches on some, but not all files I'll pm you the link to samples when they finish uploading. Btw, the source files from those albums report as "correct" rip, while the converted one are reported as "not a correct gapless rip" - trimming is not enabled.
suggestion: why not use the corresponding decoding features of lossless formats to decode to wav instead of ffmpeg? Who knows what it might be discarding upon extraction. And since you already package them to be able to encode, why not?

I've downloaded samples you sent me and encoded them to flac. I've used foobar's "Bit-Compare" tool and it says files are identical, foobar also reports same amount of samples for each file. I've used ffprobe to double check and result is the same. I'm guessing your copy of TAC still doesn't have the option to turn-off trimming completely.

I think ffmpeg works fine as general purpose decoder. The reason it is used as decoder is that TAC is actually a fork of TX264 (x264 GUI written by me) and ffmpeg was used as audio decoder there in that project.

Here is a link to the build I used to get results I talked above: https://dl.dropboxusercontent.com/u/9617171...it_build2762.7z (includes new stuff like CD ripper, dts encoding etc.)

TAudioConverter

Reply #610
Great update, testing CD Rip right now.

edit:
There are few things I don't like about the way it works but I have to think about it.


TAudioConverter

Reply #612
I should've said that this isn't a beta release, just a snapshot to see if some changes works for ChronoSphere.

@o-l-a-v I know about that but I couldn't find the source of it.

BTW you may ask why TAC runs a seperate process to do CD ripping. CD ripper library (CDRip122.dll) and it's wrapper don't have 64 bit versions (AFAIK). So I had to create a 32 bit executable that can be called from TAC.exe and communicate with it some way.

TAudioConverter

Reply #613
Tested the new build, ticking the "don't use trimming" results in correct audio checksums. Is there any reason why it's not ticked by default? Why use trimming anyway (except when the user wants to actually cut out a part of the song)?

BTW, if you have files queued, then go to cd ripper and back, it automatically starts the encoding process. You probably know that since that's just a snapshot but I thought I let you know. Oh and CD ripper doesn't seem to have unicode support yet, non-latin characters appear as ????
Do you plan to have some sort of accuraterip/CTDB integration later on?

TAudioConverter

Reply #614
Ah, one more thing: please allow to edit the command line parameter for the selected codec, or rather a possibility to define a custom codec.
Main reason being, TAC currently only uses takc in single-threaded mode it seems - encoding with TAC reports a speed of 100x, while CUETools with custom command line (4 threads) manages 200x+

TAudioConverter

Reply #615
Trimming will be disabled by default from now on. I've also added an option to start encoding as soon as cd ripping is done. If it is not selected, after ripping cd tracks to wav files, it'll just return to main window. I have Turkish and English CDs and they seem to be working fine. I'll try to find a non-latin CD.

How do you run takc in multithread mode? I couldn't see any options for that.

@o-l-a-v I've fixed your problem.

TAudioConverter

Reply #616
That avatar.
Ahem. Newest takc.exe has a -tn# switch which accepts 1-4(default:1) as parameter. So for my CPU it would be better to use -tn4 than have 4 processes running.
Btw, it's similar for the flaccl, since it's using the GPU, having more than one process for it slows it down, at least on my GPU (260GTX).

TAudioConverter

Reply #617
Silly of me, I saw -cpu switch but missed that one. I'll try it when I have time, adding that option for tak is easy.

Apophis is my favourite goa'uld these days.

TAudioConverter

Reply #618
BTW, I messed with some files and I somehow can't reproduce my 200x results with tak, I think CUETools was still counting speed even for files that got skipped because of being non-ansi (it doesn't have a workaround for that, unlike TAC ), so the results were inaccurate.

I now have following timings:
TAC: 4x processes, 1x thread, m4, 0:46, 131x
CUETools: 1x process, 4x threads, m4, 0:50, 123x
foobar: 1x processes, 4x threads, m4,  0:50, 123x
foobar: 4x processes, 1x threads, m4, 0:35, 180x

Until TBeck optimizes threading, it looks like single threading + multiple instances are the way to go.

TAC has quite some overhead though, I guess the whole process needs streamlining.
For example, I have a dual CD album which has 57 tracks in total. I loaded it into RAM to avoid as many I/O bottlenecks as possible, the output is being written to RAM as well. Same goes for the temp directory. The results are as follows:

TAC:
- adding files to list: 0:15
- generating command list: 0:10
- convert: 0:46
-------------------------------------
- total: 1:11

CUETools:
- adding files to list: 0:00
- checking CTDB: 0:02
- convert: 0:50
-------------------------------------
- total: 0:52

Foobar2000:
- adding files to list: 0:01
- selecting preset: 0:02
- convert: 0:36
-------------------------------------
- total: 0:39


I'd also like to request the following:
- an option to transfer gain for lossless -> lossy/lossy -> lossy conversion (with a warning the values might be off, displayed when ticking it)
- for TAK: add an option to turn on -md5 and -v switches (saving checksum to file and verify on encode), also the maximum preset currently used is -4, there is also -4e and -4m, can we have those please?
- for FLAC: --verify option as above

I hope you don't take my feedback negatively, your program is still the closest to what I need to painlessly keep folder structure when converting, which is quite important to me

As for goa'ulds, I think Baal is first place for me... followed by Apophis.

TAudioConverter

Reply #619
Well, TAC runs many backends to do some tasks that other tools might be doing themselves (extracting cover art, getting file info etc), I think this causes extra time.

I ripped a CD (Turkish tags) to m4a and flac, entering some tags myself in Japanese (黒の契約者, a tag from a sample you've sent me). Created files have proper tags and file names. So I'm guessing problem is at querying from freedb.

I'll add the options you proposed. And feedbacks are always welcome.

TAudioConverter

Reply #620
Yes, your tagging already seems to be UTF-8 aware. Briefly looking around the freedb page, it seems like you are just assuming the query result being ANSI, not testing if it might be UTF-8. I'm not sure if they are using UTF-8 with or without a BOM, but if it's with a BOM, then you can test if the query result contains 0xEF,0xBB,0xBF as the first 3 characters and switch to UTF-8 parsing if needed. Source: wikipedia.

TAudioConverter

Reply #621
I'll try to find information about how to query tags for CDs from freedb in order to write my own library/class. Currently I'm using newac library for that.

A bit off-topic and I'm a bit uncomfortable with the subject, but one ad company contacted me to have their ads in TAC installer. Now, I don't like ad supported software myself and I considered rejecting the offer right away but revenues from that may help me work on TAC full time. I got great help and feedback from this community so far, so I was wondering what you guys think about it.

TAudioConverter

Reply #622
As long as it's only the installer and we have the option to untick and install the software only, I don't really mind. Having ads in the program itself or worse, having to install adware to get full features is a big no-no for me though.

Also, concerning lossless->lossy RG transfer, I don't think it will work, as only copying the gain tags essentially produces non-spec-conforming files, which only foobar handles "properly" so far. The spec states that a file has to have the following 4 tags: album gain+peak, track gain+peak. The gain is nearly identical between lossless and lossy, but the peak is not. Calculating the track peak would be possible during or after conversion, but the album peak is much harder since you don't have any means to see if those tracks contain all the tracks of the album (album tag only tells you they're from same album, but not the song count).

Same issue happens with lossy->lossy, so I guess it's better to leave RG transfer lossless only after all.

TAudioConverter

Reply #623
@ChronoSphere
I think using protocol 6 instead of 5 solves the problem. I bypassed cddb library's char encoding detection and assumed returned result was always UTF-8 and it seems to work. There used to be some problems with some Turkish chars ("ı" being converted to "i" for instance) and now everything is OK here. I've uploaded TCDRipper.exe to dropbox in case you want to try it yourself: https://dl.dropboxusercontent.com/u/9617171/TCDRipper.7z place it to ..\tools\TCDripper folder. I hope this solves the problem.

If copying RG from lossless to lossy will break the files, I won't add it.

Also thanks for your insight about ads.

TAudioConverter

Reply #624
Beta build 2768 changes:
Quote
Added: CD ripper
Added: dcaenc (dts encoding)
Added: Trimming is disabled by default
Added: An option to clear the file list after encoding
Added: '0' will be added to track number if it is smaller than 10
Added: An option to run encoder as soon as cd ripping is done
Added: TTagger will now read tags from ini file
Added: Flac verify; TAK verify, evaluation level and md5 options
Added: TAC will automatically downmix to stereo if AAC-HEv2 is selected
Improved: Tag fields for APEv2
Fixed: TAK options weren't saved/loaded
Fixed: Extracted artworks weren't renamed
Fixed: Couldn't writte artwork if tags were disabled
Fixed: TCDRipper couldn't grab UTF-8 tags
Fixed: Copied RG tags for APEv2 were written even if they were empty
Fixed: "Copy Audio" caused whole cue sheet wave file to be copied to output
Fixed: FFMpeg progress wasn't shown properly
Fixed: A "Division by 0" bug when computing compression ratios
Fixed: "Custom folder tree" didn't work if custom tags were used
Fixed: Some controls weren't drawn properly after encoding done/stopped
Fixed: GUI got distored after cd ripping if skin was disabled
Fixed: Couldn't write tags to fdkaac encoded aac files in some rare cases
Fixed: TTagger couldn't write artwork because artwork file was being used by an other TTagger process
Removed: Lyric downloader

Link to downloads: https://bitbucket.org/ozok/taudioconverter-...erter/downloads