IPB

Welcome Guest ( Log In | Register )

VisualOn AAC Encoder
Nic
post Apr 19 2011, 23:20
Post #1





Group: Developer
Posts: 65
Joined: 23-September 01
Member No.: 11



Hi,

Apologies if I have missed it, but has the VisualOn AAC Encoder been checked out by you guys? It's recently been added in as an optional encoder for ffmpeg, but not sure how it compares to the great AAC encoders (one imagines it fares better than ffmpeg's current internal encoder)

The README of the library says:
QUOTE
VisualOn AAC encoder library

This library contains an encoder implementation of the Advanced Audio
Coding (AAC) audio codec. The library is based on a codec implementation
by VisualOn as part of the Stagefright framework from the Google
Android project.


Anyway, couldn't get my current MSYS/MinGW environment to compile it from https://github.com/mstorsjo/vo-aacenc so I just whacked it all in Visual Studio 6.

If you're in the mood grab it from (Edit: patent violation removed) and give it a test. Its little test app is simple and old school so writes out to ADTS AAC files rather than MP4. Usage Example: vo-aacenc.exe -r 128000 RhymePays.wav RhymePays.aac

I doubt it's great - but would be interested to know how far some good ears consider it behind the mighty Neros and Apples of this world....

Cheers,
-Nic

This post has been edited by Garf: Jul 12 2012, 16:39
Go to the top of the page
+Quote Post
 
Start new topic
Replies
stereotype
post Apr 29 2011, 04:22
Post #2





Group: Members
Posts: 40
Joined: 6-November 06
Member No.: 37260



Isn't this just like LAME? Source code only, free speech, etc...
Go to the top of the page
+Quote Post
Garf
post Apr 29 2011, 09:26
Post #3


Server Admin


Group: Admin
Posts: 4885
Joined: 24-September 01
Member No.: 13



QUOTE (stereotype @ Apr 29 2011, 05:22) *
Isn't this just like LAME? Source code only, free speech, etc...


LAME issue is related to patents. This has nothing to do with patents, it is about copyright.
Go to the top of the page
+Quote Post
aconverse
post Jun 9 2011, 20:19
Post #4





Group: Members
Posts: 19
Joined: 13-July 08
Member No.: 55753



QUOTE (Garf @ Apr 29 2011, 03:26) *
QUOTE (stereotype @ Apr 29 2011, 05:22) *
Isn't this just like LAME? Source code only, free speech, etc...


LAME issue is related to patents. This has nothing to do with patents, it is about copyright.


Until version 3.81 LAME included ISO dist10 source code (hence "Lame Aint an MP3 Encoder") so there is a similarity.

FWIW faac and faad1 also use ISO reference code.
Go to the top of the page
+Quote Post
Garf
post Jul 5 2011, 11:24
Post #5


Server Admin


Group: Admin
Posts: 4885
Joined: 24-September 01
Member No.: 13



QUOTE (aconverse @ Jun 9 2011, 21:19) *
QUOTE (Garf @ Apr 29 2011, 03:26) *
QUOTE (stereotype @ Apr 29 2011, 05:22) *
Isn't this just like LAME? Source code only, free speech, etc...


LAME issue is related to patents. This has nothing to do with patents, it is about copyright.


Until version 3.81 LAME included ISO dist10 source code (hence "Lame Aint an MP3 Encoder") so there is a similarity.

FWIW faac and faad1 also use ISO reference code.


There is no similarity wrt. patents. LAME doesn't ship executables because those actually infringe the patents, unlike source code that doesn't do anything. Google is shipping this code in executable form on Android. But again, this is not about patents, so this is completely and utterly irrelevant.

This also isn't about ISO reference code. It's about 3GPP reference code. They're most certainly not the same. Notably, the 3GPP reference code doesn't suck smile.gif
Go to the top of the page
+Quote Post
benski
post Jul 5 2011, 15:44
Post #6


Winamp Developer


Group: Developer
Posts: 670
Joined: 17-July 05
From: Brooklyn, NY
Member No.: 23375



QUOTE (Garf @ Jul 5 2011, 06:24) *
QUOTE (aconverse @ Jun 9 2011, 21:19) *
QUOTE (Garf @ Apr 29 2011, 03:26) *
QUOTE (stereotype @ Apr 29 2011, 05:22) *
Isn't this just like LAME? Source code only, free speech, etc...


LAME issue is related to patents. This has nothing to do with patents, it is about copyright.


Until version 3.81 LAME included ISO dist10 source code (hence "Lame Aint an MP3 Encoder") so there is a similarity.

FWIW faac and faad1 also use ISO reference code.


There is no similarity wrt. patents. LAME doesn't ship executables because those actually infringe the patents, unlike source code that doesn't do anything. Google is shipping this code in executable form on Android. But again, this is not about patents, so this is completely and utterly irrelevant.

This also isn't about ISO reference code. It's about 3GPP reference code. They're most certainly not the same. Notably, the 3GPP reference code doesn't suck smile.gif


I am not a lawyer, but I don't believe there is anything wrong in using the 3GPP or ISO code in binary form in a standards-compliant product (weird license text aside). The issue that Google has here is that they've potentially republished 3GPP source code under their own copyright notice and license text.
Go to the top of the page
+Quote Post

Posts in this topic
- Nic   VisualOn AAC Encoder   Apr 19 2011, 23:20
- - Garf   Looks suspiciously like the 3GPP reference code fr...   Apr 20 2011, 08:23
- - Nic   Very interesting Garf - I was not aware of that, i...   Apr 20 2011, 08:41
- - menno   The 3GPP website is pretty clear about this: http:...   Apr 28 2011, 16:03
- - Garf   Reported to Google as Android issue 16431. It...   Apr 28 2011, 19:32
- - Ivan Dimkovic   QUOTE (Nic @ Apr 20 2011, 07:41) Very int...   Apr 28 2011, 23:31
|- - Garf   QUOTE (Ivan Dimkovic @ Apr 29 2011, 00:31...   Apr 29 2011, 09:29
- - stereotype   Isn't this just like LAME? Source code only, f...   Apr 29 2011, 04:22
|- - Garf   QUOTE (stereotype @ Apr 29 2011, 05:22) I...   Apr 29 2011, 09:26
|- - aconverse   QUOTE (Garf @ Apr 29 2011, 03:26) QUOTE (...   Jun 9 2011, 20:19
|- - Garf   QUOTE (aconverse @ Jun 9 2011, 21:19) QUO...   Jul 5 2011, 11:24
|- - benski   QUOTE (Garf @ Jul 5 2011, 06:24) QUOTE (a...   Jul 5 2011, 15:44
- - Garf   FWIW, Google has closed this issue, essentially de...   May 23 2011, 22:02
- - LigH   Is vo-aacenc at all able to create HE-AAC or quali...   Oct 14 2011, 09:30
- - lvqcl   Amazing encoder. Sounds like sh#t even at 320 kbps...   Dec 12 2011, 15:42
- - LigH   It was originally made for Android, but Nic was ab...   Dec 12 2011, 15:47
- - nu774   I tried this before. One song was quite easily ABX...   Dec 12 2011, 16:27
- - LigH   As long as it is not comparable to FAAC, not to me...   Dec 12 2011, 16:43
- - smok3   just some observations: git: https://github.com/m...   Jan 22 2012, 01:03
- - IgorC   Some results of one particular person. http://d.h...   Jan 22 2012, 02:58
- - smok3   Nice, so it does not really make sense to use Visu...   Jan 22 2012, 08:22
- - lvqcl   QUOTE (smok3 @ Jan 22 2012, 04:03) I did ...   Jan 22 2012, 09:48
- - nu774   What I tried was this song (and next song in this ...   Jan 22 2012, 14:15
|- - /mnt   QUOTE (nu774 @ Jan 22 2012, 14:15) What I...   Jan 22 2012, 19:00
- - smok3   Thanks, finally found some time to patch my script...   Jan 23 2012, 00:02


Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 18th September 2014 - 21:37