IPB

Welcome Guest ( Log In | Register )

Replaygain at high sample rate, currently replaygain only works upto 48 khz
Ernst
post Oct 5 2010, 14:22
Post #1





Group: Members
Posts: 3
Joined: 5-October 10
Member No.: 84356



Hi,

I noticed that replaygain (as applied by metaflac) only works on tracks with a sample rate upto 48 khz.
I'd like to apply it to all my audio files and I do now have some with 88.2, 96, or 192 khz sample rate.
Looking into the code I see the following:
CODE
FLAC__bool grabbag__replaygain_is_valid_sample_frequency(unsigned sample_frequency)
{
    static const unsigned valid_sample_rates[] = {
        8000,
        11025,
        12000,
        16000,
        22050,
        24000,
        32000,
        44100,
        48000
    };
    static const unsigned n_valid_sample_rates = sizeof(valid_sample_rates) / sizeof(valid_sample_rates[0]);

    unsigned i;

    for(i = 0; i < n_valid_sample_rates; i++)
        if(sample_frequency == valid_sample_rates[i])
            return true;
    return false;
}


In other words, a limit, but it looks as if I could just add other values. However, 96khz would go over the unsigned 16-bit integer limit, so changing to 32-bit integers might be necessary. Would this make anything run into trouble? I've yet to try, which I'll hopefully do later today.

Now the guesswork:
Have these rates been chosen as commonly used?
Is this check at all necessary? Isn't it enough for the sampling rate to be a positive integer?
Is this only in the flac implementation or is this part of the proposed replaygain specification?
Is the reason for the lack of higher sampling rates that at the time calculation for them would have been very slow (in this case it would be better to put up a warning instead)?
Is this because the replaygain reference values are based on psychoacoustics and those are lacking for frequencies we don't hear but which would be present in the higher sampling rate signals?
Go to the top of the page
+Quote Post
 
Start new topic
Replies
Wombat
post Jan 8 2012, 21:08
Post #2





Group: Members
Posts: 1120
Joined: 7-October 01
Member No.: 235



When i remember right it was asked a long time ago to add support for higher sampling rates into metaflac. Unfortunately i didnīt see much action taking place regarding the developement of flac/metaflac.
Most likely Mr. Coalson has better things to do lately. The bugtracker at sourceforge doesnīt indicate much operation also. I even would like to have a metaflac with the chance to use R128 standard as alternate choice.
Go to the top of the page
+Quote Post

Posts in this topic


Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 25th December 2014 - 23:18