IPB

Welcome Guest ( Log In | Register )

74 Pages V  « < 22 23 24 25 26 > »   
Reply to this topicStart new topic
REACT 2 Released, New version of this popular ripping tool
pholzmann
post Aug 19 2007, 02:13
Post #576





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



Update:
QUOTE (pholzmann @ Aug 18 2007, 15:05) *
QUESTIONS:
c) In the case of this good-but-AR-thinks-not, I get the following result
- Full rip to wav
- REACT skips making the FLAC file
- But the MP3 files ARE created
- I get no indication of error or trouble... just missing flac file(s)!

Your thoughts on this last one especially appreciated. I can't get REACT to make the flac file! No error messages, it just doesn't do it.


SOLVED that one... Very strange. Turns out the album art downloader found a GIF file, saved as JPG, and got everything confused. Resaving as a real JPG fixed the flac process. All other questions do remain...

thx
Go to the top of the page
+Quote Post
mogorp
post Aug 19 2007, 13:58
Post #577





Group: Members
Posts: 22
Joined: 1-November 06
Member No.: 37046



I haven't been following this since the new version of EAC came out. Is there a command to get REACT to use the new test and copy image function?
Go to the top of the page
+Quote Post
288db
post Aug 19 2007, 16:14
Post #578





Group: Members
Posts: 8
Joined: 19-June 05
Member No.: 22848



QUOTE (mogorp @ Aug 19 2007, 07:58) *
I haven't been following this since the new version of EAC came out. Is there a command to get REACT to use the new test and copy image function?


Yes. You would add Test=1 to the react.ini file and use F10 as the image hotkey. It would look like below:
CODE
[Settings]
Version=2.0.ssb16b
ImageExt=flac
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F6}
Test=1
.....


I'm using EAC .99 prebeta 3 and REACT 2.0.ssb16b.

This post has been edited by ziptrx: Aug 19 2007, 16:16
Go to the top of the page
+Quote Post
Stone Free
post Aug 19 2007, 18:10
Post #579





Group: Members
Posts: 57
Joined: 24-September 04
From: London
Member No.: 17277



I had been using the b10 version of the mod and when I tried to rip a various artists CD from the Uni Bands society for a bit of nostalgia, I found the .FLAC track rips only contained the track numbers and the dash character but no band or title.

The tracks are titled Song - Artist, and the CD Artist says Various and the Various Artists checkbox is ticked

I have just tried upgrading to beta 16, but this has not fixed the issue.

Here is my track cfg file:

CODE
@ECHO OFF
CHCP 1252
TITLE @track@/@numtracks@ - "@album@"
REM Copyright © Tycho, 2006
REM
REM ** Create compressed audio tracks from ripped .wav tracks.
REM **
REM ** You may consider using image mode (F10)
REM ** as it supports creating tracks via acdir.exe,
REM ** and post-processing will always work (see below).
REM **
REM ** Flac requires flac.exe/metaflac.exe (v1.1.3)
REM ** NeroAac requires NeroAacEnc.exe/NeroAacTag.exe/AacGain.exe.
REM ** OggEnc2 requires OggEnc2.exe/VorbisGain.exe.
REM **
REM ** I prefer applying album gain 92dB to get a reasonable
REM ** volume for my DAP. The RG tags are still relative
REM ** to 89dB SPL, i.e. album gain will be about -3.0dB.


REM ============== Begin Main Script ==================


IF @Debug@==1 ECHO ON

SET TrackDir_Flac="@TrackDir_Flac@"
SET TrackDir_Wavpack="@TrackDir_Wavpack@"
SET TrackDir_MP3="@TrackDir_MP3@"
SET TrackDir_AAC="@TrackDir_AAC@"
SET TrackDir_OGG="@TrackDir_OGG@"

IF @various@==0 SET TrackName=@TrackName_SA@
IF @various@==1 SET TrackName=@TrackName_VA@

SET realNumTracks=@numtracks@
IF [@datadisc@] EQU [1] SET /a realNumTracks=@numtracks@-1

SET have_cover=0
SET embed_cover=0

IF EXIST "@cover@" (
SET have_cover=1
SET embed_cover=@EmbedCover@
)

REM ---- Track ----


IF NOT @Flac@==1 GOTO end_flac_tracks
IF NOT EXIST %TrackDir_Flac% MKDIR %TrackDir_Flac%
PUSHD %TrackDir_Flac%
IF @various@==1 SET VA_tag=-T "album artist=@VA@"
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"
ECHO ON
@tools@\flac.exe @Opt_Flac@ %Cover_tag% %VA_tag% -T artist="@artist@" -T

album="@album@" -T tracknumber="@track@/@numtracks@" -T title="@title@" -T date="@year@" -T

genre="@genre@" -T comment="@comment@" -T encoded-by="%USERNAME%" -T encoding="Flac @Ver_Flac@

@Opt_Flac@" "@source@" -o "%TrackName%.flac"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_flac_tracks


IF NOT @Wavpack@==1 GOTO end_wavpack_tracks
IF NOT EXIST %TrackDir_Wavpack% MKDIR %TrackDir_Wavpack%
PUSHD %TrackDir_Wavpack%
IF @various@==1 SET VA_tag=-w "album artist=@VA@"
ECHO ON
@tools@\wavpack.exe @Opt_Wavpack@ %VA_tag% -w artist="@artist@" -w album="@album@" -w

track="@track@/@numtracks@" -w title="@title@" -w year="@year@" -w genre="@genre@" -w

comment="@comment@" -w encodedby="%USERNAME%" -w encodersettings="Wavpack @Ver_Wavpack@

@Opt_Wavpack@" "@source@" "%TrackName%.wv"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
TITLE @track@/@numtracks@ - "@album@"
POPD
:end_wavpack_tracks


IF NOT @LameMP3@==1 GOTO end_lame_tracks
IF NOT EXIST %TrackDir_MP3% MKDIR %TrackDir_MP3%
PUSHD %TrackDir_MP3%
IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"
IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"
ECHO ON
@tools@\lame.exe @Opt_LameMP3@ "@source@" "%TrackName%.mp3"
@tools@\metamp3.exe %Cover_tag% %VA_tag% --artist "@artist@" --album "@album@"

--track @track@/@numtracks@ --title "@title@" --year "@year@" --genre "@genre@" --comment "@comment@"

--frame TENC:"%USERNAME%" --frame TSSE:"LAME @Ver_LameMP3@ @Opt_LameMP3@" "%TrackName%.mp3"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_lame_tracks


IF NOT @iTunesAac@==1 GOTO end_itunes_aac_tracks
IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
PUSHD %TrackDir_AAC%
IF %embed_cover%==1 SET Cover_tag=-r "@cover@"
ECHO ON
@tools@\iTunesEncode.exe @Opt_iTunesAac@ -e "AAC Encoder" %Cover_tag% -x @various@ -a

"@artist@" -l "@album@" -n "@track@" -m "@numtracks@" -t "@title@" -y "@year@" -g "@genre@" -c

"@comment@" -i "@source@" -o "%TrackName%.m4a"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
GOTO end_nero_aac_tracks
:end_itunes_aac_tracks

IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
IF NOT EXIST %TrackDir_AAC% MKDIR %TrackDir_AAC%
PUSHD %TrackDir_AAC%
IF @various@==1 SET VA_tag=--albumArtist "@VA@" --compilation true
IF %embed_cover%==1 SET Cover_tag=--artwork "@cover@"
ECHO ON
@tools@\neroAacEnc.exe @Opt_NeroAac@ -if "@source@" -of "%TrackName%.m4a"
@tools@\AtomicParsley.exe "%TrackName%.m4a" -o REACT_tmp.m4a %Cover_tag% %VA_tag%

--artist "@artist@" --album "@album@" --tracknum "@track@/@numtracks@" --title "@title@" --year

"@year@" --genre "@genre@" --comment "@comment@" --encodingTool "neroAacEnc @Ver_NeroAac@

@Opt_NeroAac@"
@ECHO OFF
MOVE /Y REACT_tmp.m4a "%TrackName%.m4a"
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_nero_aac_tracks


IF NOT @OggEnc2@==1 GOTO end_oggenc_tracks
IF NOT EXIST %TrackDir_OGG% MKDIR %TrackDir_OGG%
PUSHD %TrackDir_OGG%
IF @various@==1 SET VA_tag=-c "album artist=@VA@"
ECHO ON
@tools@\oggenc2.exe @Opt_OggEnc2@ %VA_tag% -c artist="@artist@" -c album="@album@" -c

tracknumber="@track@/@numtracks@" -c title="@title@" -c date="@year@" -c genre="@genre@" -c

comment="@comment@" -c encoded-by="%USERNAME%" -c encoding="OggEnc @Ver_OggEnc2@ @Opt_OggEnc2@"

"@source@" -o "%TrackName%.ogg"
@ECHO OFF
IF %have_cover%==1 IF NOT EXIST folder.jpg COPY "@cover@" folder.jpg
POPD
:end_oggenc_tracks
IF @Debug@==1 ECHO ON

REM ** Delete the source .wav
DEL "@source@"


REM ---- Post-processing ----


rem ** Scan and compute ReplayGain and add cover picture for supported formats.
rem ** NB: The following will only work if at least the last track is selected,
rem ** and it is a regular audio track.

rem IF NOT @track@==@numtracks@ GOTO end_post_process
IF [@track@] NEQ [%realNumTracks%] GOTO end_post_process

SET add_rg=@ReplayGain@
SET aac_enc=@NeroAac@
IF @iTunesAac@==1 SET aac_enc=1

IF NOT @ReplayGain@==1 GOTO end_RG
SET RG_MetaFlac=--add-replay-gain
SET RG_MetaMP3=--replay-gain
:end_RG

IF NOT @ApplyAlbumGain@==1 GOTO end_apply_AG
SET RG_MetaMP3=--apply-gain album@AdjustAlbumGain_dB@
SET RG_AacGain=/a /o /c /d @AdjustAlbumGain_dB@
SET add_rg=1
:end_apply_AG


REM ** Audio Formats:

IF @Flac@==1 (
PUSHD %TrackDir_Flac%
IF %add_rg%==1 @tools@\Glob.exe -v -c @tools@\metaflac.exe %RG_MetaFlac%

*.flac
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF @Wavpack@==1 (
PUSHD %TrackDir_Wavpack%
IF %add_rg%==1 @tools@\wvgain.exe -a *.wv
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF @LameMP3@==1 (
PUSHD %TrackDir_MP3%
IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF %aac_enc%==1 (
PUSHD %TrackDir_AAC%
IF %add_rg%==1 @tools@\aacgain.exe %RG_AacGain% *.m4a > "gainlog.txt"
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)

IF @OggEnc2@==1 (
PUSHD %TrackDir_OGG%
IF %add_rg%==1 @tools@\vorbisgain.exe -a *.ogg
REM COPY /Y "@eaclog@" "EAClog.txt"
POPD
)


REM ** Cleanup

DEL "@eaclog@"
DEL "@albumfile@.[*].cue"
DEL "@cover@"

:end_post_process


REM ================ End Main Script ===================


IF @Debug@==1 (
PAUSE
EXIT
)

REM ** Delete this .bat file:
DEL %0


This post has been edited by Synthetic Soul: Aug 19 2007, 19:04
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 19 2007, 19:08
Post #580





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



Added CODEBOX tags added to your post. Can you post your INI file using CODEBOX tags please?

Also, try adding DebugMode=1 in the UserSettings section of REACT.ini, and then posting the contents of debugging.txt which will be created in your REACT folder (again, using CODEBOX).


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
Stone Free
post Aug 19 2007, 19:26
Post #581





Group: Members
Posts: 57
Joined: 24-September 04
From: London
Member No.: 17277



OK Heres the .INI,

CODE

[Settings]
Version=2.0.ssb16b
ImageExt=flac
ImageNaming=$artist$ - [$year$] $album$
ImageHotKey={F10}
TracksHotKey={F4}
TracksHotVal=+{F5}
VA=Various Artists
CreateAllCuesheets=0
RunCoverDownloader=0
CoverDownloader=C:\Program Files\Audio\REACT2\coverdownloader\albumart.exe
EAC=C:\Program Files\Audio\Exact Audio Copy\EAC.exe
Tools=C:\Program Files\Audio\REACT2\tools
MinimizeCompressionWindow=1
ProcessPriority=1
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]

[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=0
NeroAac=0
iTunesAac=0
OggEnc2=0

[UserOutputNames]
;OutRoot=@mymusic@\EAC
OutRoot=D:\
ImageDir_Flac=@OutRoot@\FLAC-images\$cdartist$
ImageDir_Wavpack=@OutRoot@\WV-images\$cdartist$
ImageDir_MP3=@OutRoot@\MP3-images\$cdartist$
TrackDir_Flac=@OutRoot@\CDs\$cdartist$\$album$
TrackDir_Wavpack=@OutRoot@\CDs\$cdartist$\$album$
TrackDir_MP3=@OutRoot@\MP3\$cdartist$\[$year$] $album$
TrackDir_AAC=@OutRoot@\AAC\$cdartist$\[$year$] $album$
TrackDir_OGG=@OutRoot@\OGG\$cdartist$\[$year$] $album$
TrackName_SA=$track$ - $title$
TrackName_VA=$track$ - $title$
TrackName_VA_acdir=$n - $~t [$~a]
TrackName_SA_acdir=$n - $~t


[UserSettings]
Debug=0
Comment=Created with EAC/REACT2, @curdate@
EmbedCover=1
ReplayGain=0
ApplyAlbumGain=1
AdjustAlbumGain_dB=+5.0
AddCuesheetAG=0
UseWaveGainAG=0
Opt_Flac=-8 -f
Opt_Wavpack=-hmy -c -b192 -n -x3
Opt_LameMP3=-V5 --vbr-new --noreplaygain --nohist
Opt_NeroAac=-lc -q 0.21
Opt_iTunesAac=-d -s 2000
Opt_OggEnc2=-q 3.0
Ver_Flac=1.1.4
Ver_Wavpack=4.40
Ver_LameMP3=3.97
Ver_NeroAac=1.0.0.2
Ver_OggEnc2=2.83 Lancer aoTuV b5

[DefaultMetaData]
discnumber=1
totaldiscs=1
discname=


will come back to you with the debug output

Do I have to rip the entire disk to get debugging.txt because I see no text files generated?
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 19 2007, 19:50
Post #582





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



Yes, you do.

However, after re-reading your post, I am wondring about the part where you say "The tracks are titled Song - Artist", as the proper format for a VA disc is "Artist / Title". This is likely to be your problem.


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
Stone Free
post Aug 19 2007, 20:03
Post #583





Group: Members
Posts: 57
Joined: 24-September 04
From: London
Member No.: 17277



QUOTE (Synthetic Soul @ Aug 19 2007, 19:50) *
Yes, you do.

However, after re-reading your post, I am wondring about the part where you say "The tracks are titled Song - Artist", as the proper format for a VA disc is "Artist / Title". This is likely to be your problem.

Well ripped entire album and still no debugging .txt

CODE

POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>IF 0 == 1 (
PUSHD "D:\\MP3\Various Artists\[] Above & Beyond"
IF 1 == 1 C:\PROGRA~1\Audio\REACT2\tools\metamp3.exe --apply-gain album+5.0 *.m
p3
REM COPY /Y "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log" "EAClog.txt"
POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>IF 0 == 1 (
PUSHD "D:\\AAC\Various Artists\[] Above & Beyond"
IF 1 == 1 C:\PROGRA~1\Audio\REACT2\tools\aacgain.exe /a /o /c /d +5.0 *.m4a 1>
"gainlog.txt"
REM COPY /Y "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log" "EAClog.txt"
POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>IF 0 == 1 (
PUSHD "D:\\OGG\Various Artists\[] Above & Beyond"
IF 1 == 1 C:\PROGRA~1\Audio\REACT2\tools\vorbisgain.exe -a *.ogg
REM COPY /Y "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log" "EAClog.txt"
POPD
)

C:\Documents and Settings\Peter\My Documents\My Music>REM ** Cleanup

C:\Documents and Settings\Peter\My Documents\My Music>DEL "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.log"

C:\Documents and Settings\Peter\My Documents\My Music>DEL "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.[*].cue"
Could Not Find C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.[*].cue

C:\Documents and Settings\Peter\My Documents\My Music>DEL "C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.jpg"
Could Not Find C:\Documents and Settings\Peter\My Documents\My Music\Above & Beyond.jpg

C:\Documents and Settings\Peter\My Documents\My Music>REM ================ End Main Script ===================

C:\Documents and Settings\Peter\My Documents\My Music>IF 1 == 1 (
PAUSE
EXIT
)
Press any key to continue . . .

Will try swapping round artist and track and replacing - with /

This post has been edited by Stone Free: Aug 19 2007, 20:04
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 19 2007, 20:11
Post #584





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



QUOTE (pholzmann @ Aug 19 2007, 00:05) *
I have reason to suspect the GUI is interacting with other windows in various "wait for XYZZY to happen" ways... see below. I'll try ssb17 when it's ready...
The AMD GUI does not rely on anything else. I am undecided about releasing b17. I don't think it would help you anyway.

QUOTE (pholzmann @ Aug 19 2007, 00:05) *
2) After performing several rips, the albumart software does not fire up the first time I press F10. If I wait for the gap-find to complete, wait another minute or two, then press F10 again, it goes forward. I think this relates to the comment elsewhere in this thread about REACT slowing down after many rips.

a) Idea: could it be NOT fully resetting after the CD is removed and/or while firing up the next Rip? I'm guessing that something is waiting for a window to complete or close or ???

b) It would help to have a keystroke that does a "full reset-- restart REACT as if just opened"... for those strange error situations
This is definitely a concern, but I'm not sure that I'm in a position to do anything about it. I can only assume that something isn't resetting, but it's a bit of a needle in a haystack, and the fact that I'd need to rip numerous discs to even begin testing is a little prohibitive.

I added the functionality in b15 (IIRC) to output text to a debug file (debugging.txt). Maybe I could release a test version of REACT that wrote everything to the file, in the hope that it might highlight the problem when it occurs.

QUOTE (pholzmann @ Aug 19 2007, 00:05) *
3) It's not clear to me what REACT knows or does with respect to the AccurateRip database, and/or when a rip is unsuccessful.

QUESTIONS:
- How does REACT decide whether a RIP was completed successfully?
a) If I stop the RIP, I want REACT to not-process
b) If I let the RIP complete, if REACT thinks there was a problem, it should ask me about continuing, rather than auto-killing. It is hard for REACT to know for sure if things worked or not!
- on a C2 drive like mine, "timing error" is not a problem, usually... just means some retries happened
- it's possible to have AccurateRip tell me the rip was "bad" when it isn't. I just ripped a CD that's perfect, but it's a different pressing than the 2 copies in the DB. It worked, but AccurateRip doesn't know that.
REACT knows nothing about the AR results, whether the rip matched well, etc. EAC controls the running of REACT, so if REACT is running when you don't want it to, there's nothing REACT can do really.


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
288db
post Aug 19 2007, 20:24
Post #585





Group: Members
Posts: 8
Joined: 19-June 05
Member No.: 22848



This is resolved.

This post has been edited by ziptrx: Aug 20 2007, 16:42
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 19 2007, 22:33
Post #586





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



QUOTE (ziptrx @ Aug 19 2007, 20:24) *
I would like to start by saying thanks to all of those who have put an effort to making REACT work with no problems. I have noticed that some people, like myself, would like to be able to update files such as flac.exe, metamp3.exe and etc. Well I update acdir.exe to version .12 and have noticed that my flac image is no longer made. All mp3 and flac tracks are made and copied to the correct directories, along with the cue and jpg file being copied to the image folder, but no flac image exists. I have ran a debug and noticed nothing out of the ordinary. Any ideas?

REACT 2.0.ssb16b & EAC .99 prebeta 3. Also there are problems when upgrading flac.exe and metaflac.exe to 1.2.0 and metamp3.exe will not tag mp3s. I believe it has something to do with the commands being changed. I will look more into those once I figure out acdir
I'm surprised that changing ACDIR has caused problems - especially with the FLAC image creation in which it plays no part. I can also see no reason why you could not upgrade FLAC to the latest version, although I'm less sure about metamp3, as I'm not overly familiar with its syntax, or changes made. I believe I am using the latest beta though, with no problems or changes required.

All in all, I have no idea, sorry.


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
pholzmann
post Aug 20 2007, 01:41
Post #587





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



QUOTE (Synthetic Soul @ Aug 19 2007, 11:11) *
REACT knows nothing about the AR results, whether the rip matched well, etc. EAC controls the running of REACT, so if REACT is running when you don't want it to, there's nothing REACT can do really.


THANK YOU! Now I feel pretty dumb. It just clicked: there's the "outer" REACT that drives the UI, and the post-rip REACT that gets called as a compressor.

I think understanding my "album-art-JPG are not really jpg files" problem has cleaned up most if not all remaining anomalies. And that is decidedly NOT a REACT issue. Whew!

Thanks soooo much. This is getting smoother all the time.

I'll aim some of my more advanced debug tools at REACT to see if I can discover any hints about what is going wrong over a series of rips...

Until then,
THANKS!

--MrPete
Go to the top of the page
+Quote Post
pholzmann
post Aug 20 2007, 12:03
Post #588





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



OK, I've learned some more, and found a few things perhaps worth chewing on.

First, the CHCP command is necessary, for non-ASCII characters in filenames, like "Scott Denté" -- so I messed around with that a bit more. It's VERY strange on my (Win XP SP2, tablet edition) machine.
* It always locks up if I use "CHCP 1252" the first time a CMD window is opened
* It usually works ok if I use "CHCP 1252 | CHCP" (but not always)

I'm suspecting that some of the MS Windows extensions in support of tablet PC's is causing grief

Second, if I abort the batch file (due to CHCP lockup or whatever), in EAC using Alt-V (compress WAV's), I can get REACT to create and run the appropriate batch file -- **almost**. The result is almost correct but not quite:
* For FLAC single-file output: the artist folder's not created; FLAC and CUE not placed correctly, JPG not copied.
* For MP3 file-per-track output: the artist folder is created as "[]" (or maybe no artist folder, and that's the album name?. Again, MP3's placed in the mp3 "root" (as with flac), and the JPG album art is not copied

Finally, and perhaps most useful: while monitoring REACT over an extended period using System internals' Filemon.exe app, I found REACT got into a continuous background loop trying to open the CUE file for one of my rips. Even after later rips had been done, it would continue to attempt to open this cue file. Perhaps that's the source of the slowdown.

*Possible* related topic: does REACT properly handle semi-overlapping operations? Here's my typical workflow:
* Run REACT
* Insert CD
* Press F10, let gap-finder complete, wait for AlbumArt to load
* Pick albumart; that app auto-closes
* now EAC starts ripping
* when rip complete, REACT batch file starts waiting for the log file
* press "OK" on EAC status messages; log gets auto-written
* now the REACT batch process begins
* eject CD
* Insert new CD, wait for FreeDB to load CD info
* Press F10 and continue

NOTE that I press F10 to begin ripping the next CD, *before* the batch file completes for the previous one.

Is there any reason this should cause grief?
Go to the top of the page
+Quote Post
pholzmann
post Aug 20 2007, 14:16
Post #589





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



QUOTE (pholzmann @ Aug 20 2007, 03:03) *
Finally, and perhaps most useful: while monitoring REACT over an extended period using System internals' Filemon.exe app, I found REACT got into a continuous background loop trying to open the CUE file for one of my rips. Even after later rips had been done, it would continue to attempt to open this cue file. Perhaps that's the source of the slowdown.

*Possible* related topic: does REACT properly handle semi-overlapping operations?...


Update: definite correlation. REACT does not loop on CUE file-open attempts until I begin a new rip (F10) while the previous one is still running in EAC's "compression queue". As *soon* as I press F10, the loop-trying-to-open-CUE begins, and does not stop until I close REACT.

Also noted:

1) EAC supports the overlap quite nicely. It maintains a background compression queue, does not begin the next compression until the first one is done (I told it I only had a 2-cpu machine), etc.

2) I think I've found a satisfactory workaround for my CHCP problem. This works without lockup (so far):
CHCP 1252|prompt

3) It would be helpful in general if the batch file could check return status from FLAC, LAME, etc... and not delete files needed to re-run when there's an error.
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 20 2007, 14:32
Post #590





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



The REACT code will go into a recurring loop if one of the track cuesheets (created by specifiying CreateAllCuesheets) is not found. I could change this so that it gives up after a certain time. When looking for the log file Tycho's code will try for a maximum of five seconds (20 loops waiting 0.25 seconds between each check) perhaps I should change his fMoveCuesheet() function to do the same.

Good find. smile.gif

OK, just seen your next post. No idea why it is happening. Essentially the code sends key combinations to access EAC's menu commands to make all the types of cuesheet. So, either the key commands are not being sent, or the cuesheets just aren't being created for some reason.

I know that b15 will have a problem with the meta data if you rip in the way you do, as the data held in meta.ini will be overwritten when you eject the disc. This was fixed in b16. As for the core REACT code, I cannot really say, although I can't think where an issue might happen.

At some point, when I get some time, I will go through all the source with a fine tooth comb, trying to ascertain whether the line may cause problems in this situation, or when ripping multiple discs. The code in fMoveCuesheet() which will loop indefinately if the cueseet is not found is a prime example. At this same time I may add huge numbers of debug statements, to create b16_debug, which will output KB of debug text, but could be used to try to fix these strange issues that a few people are seeing!


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
288db
post Aug 20 2007, 16:49
Post #591





Group: Members
Posts: 8
Joined: 19-June 05
Member No.: 22848



Well after upgrading flac, metaflac and acdir, everything went fine. Once I replaced metamp3.exe with v092b5 things went wrong. I have the flac, flac image and mp3s created, but no tagging for mp3s. Problems arise at the start of creating the mp3s with metamp3.

CODE
TITLE 01/15 mp3 "The Singles 1992-2003" & C:\PROGRA~1\EXACTA~1\encoders\lame.exe
-V5 --vbr-new --noreplaygain --nohist  - "01 - Just a Girl.mp3" & C:\PROGRA~1\E
XACTA~1\encoders\metamp3.exe --pict "{3}C:\Users\Steve\Music\EAC\The Singles 199
2-2003.jpg"  --artist "No Doubt" --album "The Singles 1992-2003" --title "Just a
Girl" --track 01/15 --year "2003" --genre "Pop" --comment "FreedbID:CB0E000F" -
-frame TENC:"Steve" --frame TSSE:"LAME 3.97 -V5 --vbr-new --noreplaygain --nohis
t" "01 - Just a Girl.mp3"
LAME 3.97 32bits (http://www.mp3dev.org/)
CPU features: MMX (ASM used), 3DNow! (ASM used), SSE (ASM used)
Using polyphase lowpass filter, transition band: 15826 Hz - 16360 Hz
Encoding <stdin> to 01 - Just a Girl.mp3
Encoding as 44.1 kHz VBR(q=5) j-stereo MPEG-1 Layer III (ca. 11.9x) qval=3
'C:\PROGRA~1\EXACTA~1\encoders\metamp3.exe' is not recognized as an internal or
external command,
operable program or batch file.


I would post more from the debug, but I do not have a debug.txt file that was created. I'm looking more into the problem, but hoping others might have an idea. Thanks.
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 20 2007, 17:00
Post #592





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



It looks like it simply can't find metamp3.exe

Is it actually in "C:\Program Files\Exact Audio Copy\encoders"? If not, either change the value of the "Tools" setting under "Settings" in your REACT.ini to point to the right place (normally "C:\Program Files\REACT2\tools"), or put metamp3 in "C:\Program Files\Exact Audio Copy\encoders".


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
288db
post Aug 20 2007, 17:08
Post #593





Group: Members
Posts: 8
Joined: 19-June 05
Member No.: 22848



Argh....it's fixed finally. Jusdt rebooted and all works now. Have to love computers. laugh.gif

This post has been edited by ziptrx: Aug 20 2007, 17:58
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 20 2007, 17:16
Post #594





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



Maybe it's a runtime thing. The metamp3 thread states:

You must have the vc sp1 redististributable runtime libraries to get it working. Get it from here:
http://www.apachelounge.com/download/vcredist_x86-sp1.exe

This may only be true for the beta.

Also, see this post from Martin H. It may be worth reading on, in case things have changed.


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
pholzmann
post Aug 21 2007, 02:56
Post #595





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



QUOTE (Synthetic Soul @ Aug 20 2007, 05:32) *
The REACT code will go into a recurring loop if one of the track cuesheets (created by specifiying CreateAllCuesheets) is not found. I could change this so that it gives up after a certain time. When looking for the log file Tycho's code will try for a maximum of five seconds (20 loops waiting 0.25 seconds between each check) perhaps I should change his fMoveCuesheet() function to do the same.

Good find. smile.gif

OK, just seen your next post. No idea why it is happening. Essentially the code sends key combinations to access EAC's menu commands to make all the types of cuesheet. So, either the key commands are not being sent, or the cuesheets just aren't being created for some reason.


Update, now running ssb16b...

I'm not sure if this is normal or unexpected:
* When in this mode, REACT always looks for a "plain" Trackname.CUE file, but all the cue files are Trackname [something].cue

Good News! overlapping rips and compression works fine from the output perspective (i.e. all files in the right place, AFAIK.)

Medium News: I ripped four CD's in a row with no problem, and no CUE-loop! Unfortunately, on CD #5, FileMon says the CUElooper is back. Bleah.

BugFix Help Request: remember my problem with AlbumArt GIF/BMP downloading as JPG? Apparently, there's a setting I don't know how to set, in REACT:

At least with AlbumArt Downloader XUI, there's support for a target download file of
Trackname.%extension%

i.e. if the track is "Strawberry Fields Forever", the AlbumArt request should be
Strawberry Fields Forever.%extension%

but right now it is
Strawberry Fields Forever.jpg

Where can I fix this?

Thx muchly!!!!

MrPete
Go to the top of the page
+Quote Post
pholzmann
post Aug 21 2007, 04:35
Post #596





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



By the way, this:

CHCP 1252 | PROMPT

...has proven reliable. I recommend making it part of the default cfg. Can't explain WHY chcp hangs sometimes without it, but it is a very real effect.

thx

MrPete
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 21 2007, 07:50
Post #597





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



QUOTE (pholzmann @ Aug 21 2007, 04:35) *
By the way, this:

CHCP 1252 | PROMPT

...has proven reliable. I recommend making it part of the default cfg. Can't explain WHY chcp hangs sometimes without it, but it is a very real effect.
I don't see a reason why not. I don't understand what's happening to you.

QUOTE (pholzmann @ Aug 21 2007, 02:56) *
I'm not sure if this is normal or unexpected:
* When in this mode, REACT always looks for a "plain" Trackname.CUE file, but all the cue files are Trackname [something].cue
What mode? "Trackname" should never be used; IIRC REACT uses the album name for the four cuesheets created ("<album>.[<type>].cue"). When ripping to images it is named the same as the image file. You're ripping to tracks (using REACT-track.cfg) aren't you? Can you possibly explain further please?

QUOTE (pholzmann @ Aug 21 2007, 02:56) *
Good News! overlapping rips and compression works fine from the output perspective (i.e. all files in the right place, AFAIK.)
Great. Good to hear some good news from you!

QUOTE (pholzmann @ Aug 21 2007, 02:56) *
Medium News: I ripped four CD's in a row with no problem, and no CUE-loop! Unfortunately, on CD #5, FileMon says the CUElooper is back. Bleah.
It's strange that it will take a while to manifest itself. Thanks for the info anyway.

QUOTE (pholzmann @ Aug 21 2007, 02:56) *
BugFix Help Request: remember my problem with AlbumArt GIF/BMP downloading as JPG? Apparently, there's a setting I don't know how to set, in REACT:

At least with AlbumArt Downloader XUI, there's support for a target download file of
Trackname.%extension%

i.e. if the track is "Strawberry Fields Forever", the AlbumArt request should be
Strawberry Fields Forever.%extension%

but right now it is
Strawberry Fields Forever.jpg

Where can I fix this?
Unfortunately I am not familiar with the album art processing, as I don't use it. However, I have taken a look at the source and the AlbumArt Downloader XUI thread and I think I see that this is quite achievable. Maybe I could move the parameters used to REACT.ini. REACT currently uses:

'<artist>' '<album>' '<filename-friendly album>.jpg'

I suppose a more accurate XUI parameter string would be:

/artist '<artist>' /album '<album>' /path '<filename-friendly album>.%extension%'

However, I don't know if there is any way for REACT to know what extension was used, so when it replaces the token "@cover@" it is going to have to see if '<filename-friendly album>.jpg' exists and if not expect '<filename-friendly album>.gif'. I'm not sure if that will cause problems. Presumably the image should always be there before the batch file runs?


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 21 2007, 11:30
Post #598





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



QUOTE (pholzmann @ Aug 21 2007, 02:56) *
BugFix Help Request: remember my problem with AlbumArt GIF/BMP downloading as JPG? Apparently, there's a setting I don't know how to set, in REACT:

At least with AlbumArt Downloader XUI, there's support for a target download file of
Trackname.%extension%

i.e. if the track is "Strawberry Fields Forever", the AlbumArt request should be
Strawberry Fields Forever.%extension%

but right now it is
Strawberry Fields Forever.jpg

Where can I fix this?
Please try ssb16c. Add CoverDownloaderXUI=1 to the [Settings] section of your REACT.ini. This will then use the parameters:

CODE
/artist "<artist>" /album "<album>" /path "<album>.%extension%" /autoclose

The processing instance of REACT will look for the existence of "<album>.gif", then "<album>.png" but finally default to "<album>.jpg" without checking for it's existence. Therefore, for it to catch a non-JPEG file you will have to ensure that you are saving the image before the processing instance begins. I believe that this is default behaviour when ripping to tracks (but not images). For those interested, check out the RunCoverDownloader settings in the wiki article.

I have also made a couple of other small changes, including giving up on trying to move the cuesheet after five seconds, and a little more debug text. As said before, to view any debug text set DebugMode=1 under the [UserSettings] section and restart REACT. REACT will then output various information into debugging.txt in the REACT directory. This is not connected to the existing Debug=1 setting (Debug is useful for catching CFG-related issues; I implemented DebugMode in order for users to be able to provide information when reporting bugs).


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post
pholzmann
post Aug 21 2007, 12:37
Post #599





Group: Members
Posts: 57
Joined: 1-February 04
Member No.: 11702



QUOTE (Synthetic Soul @ Aug 20 2007, 22:50) *
QUOTE (pholzmann @ Aug 21 2007, 02:56) *
I'm not sure if this is normal or unexpected:
* When in this mode, REACT always looks for a "plain" Trackname.CUE file, but all the cue files are Trackname [something].cue
What mode? "Trackname" should never be used; IIRC REACT uses the album name for the four cuesheets created ("<album>.[<type>].cue"). When ripping to images it is named the same as the image file. You're ripping to tracks (using REACT-track.cfg) aren't you? Can you possibly explain further please?

I apologize. I got mixed up. I'm ripping images. That should have been AlbumName.cue that it searches for. "In this mode" is what I'm calling a CUEloop wink.gif... searching forever for a file, in the background.

If the album is called "Imagine", what I see is:
Folder has Imagine.[s].cue etc
but REACT is searching for Imagine.cue (and never finds it of course... particularly when i've moved on to another image!)

QUOTE
Unfortunately I am not familiar with the album art processing...I don't know if there is any way for REACT to know what extension was used, so when it replaces the token "@cover@" it is going to have to see if '<filename-friendly album>.jpg' exists and if not expect '<filename-friendly album>.gif'. I'm not sure if that will cause problems. Presumably the image should always be there before the batch file runs?

I think you're guaranteed it will be there before the batch file runs. Don't know why, but the rip does not even begin until the album art has been saved.

So far, I've seen jpg, gif and bmp album art.

For me at least, I would use the above "fix" to ensure I only pick jpg files! (The problem with "album.jpg" vs "album.%extension%" is that with the former, i get no software indication of the kind of file i'm saving...)

I'll try 16c asap...

THANKS!!!!
Go to the top of the page
+Quote Post
Synthetic Soul
post Aug 21 2007, 13:21
Post #600





Group: Super Moderator
Posts: 4887
Joined: 12-August 04
From: Exeter, UK
Member No.: 16217



QUOTE (pholzmann @ Aug 21 2007, 12:37) *
I apologize. I got mixed up. I'm ripping images. That should have been AlbumName.cue that it searches for. "In this mode" is what I'm calling a CUEloop wink.gif... searching forever for a file, in the background.

If the album is called "Imagine", what I see is:
Folder has Imagine.[s].cue etc
but REACT is searching for Imagine.cue (and never finds it of course... particularly when i've moved on to another image!)
Hmm.. if you are ripping to image you really should not be using CreatAllCuesheets to create the four cuesheets. When ripping to image a cuesheet is automatically created, using the same name as the image.

The fact that your image cuesheet is named "<album>.cue" is a concern. What value do you have set for ImageNaming under [Settings] in the ini? The default is "$artist$ - [$date$] $album$" IIRC (I use "$artist$ - $album$"). The image name must begin with $artist$! Otherwise you will have problems with VA albums.

Edit: OK, to clarify: If you use CreateAllCuesheets EAC will create four cuesheets named "<album>.cue". As REACT tells EAC to create them it then renames them to "<album>.[<type>].cue". This may be where the confusion is coming in - I am now presuming that your ImageNaming value is fine. I do think you may solve some of your problems (if not all) if you set CreateAllCuesheets=0 in your ini - you don't need them.

QUOTE (pholzmann @ Aug 21 2007, 12:37) *
I think you're guaranteed it will be there before the batch file runs. Don't know why, but the rip does not even begin until the album art has been saved.
According to the wiki, when using images it will not wait (unless you set the value to 2 or 3). if you are ripping to images perhaps you should set RunCoverDownloader to 2, in case.

QUOTE (pholzmann @ Aug 21 2007, 12:37) *
I'll try 16c asap...
Thanks. Maybe I'll upload 16d to deal with BMP as well... sad.gif

Edit: OK, ssb16d should cope with GIF, PNG, BMP and JPG.

This post has been edited by Synthetic Soul: Aug 21 2007, 13:45


--------------------
I'm on a horse.
Go to the top of the page
+Quote Post

74 Pages V  « < 22 23 24 25 26 > » 
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 2nd September 2014 - 17:09