IPB

Welcome Guest ( Log In | Register )

15 Pages V  « < 2 3 4 5 6 > »   
Reply to this topicStart new topic
Updated in_mad Winamp MAD MP3 input plugin
MedO
post Aug 7 2006, 10:35
Post #76





Group: Members
Posts: 341
Joined: 24-August 05
Member No.: 24095



QUOTE (odyssey @ Aug 7 2006, 11:02) *
Btw, is this still an error or did you correct it by writing only ID3v2.3 tags ?


QUOTE (MoSPDude @ Aug 6 2006, 02:03)
I've finally uploaded another update. ID3v2.4 tags are now written properly, on all files I tested - and can be read properly by other taggers too.


It seems that's fixed.
Go to the top of the page
+Quote Post
MoSPDude
post Aug 8 2006, 00:45
Post #77





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



The tags that are written are ID3v2.4 , there is still a bug in libid3tag when CRC is written in that no other taggers will accept it, so CRC is disabled.

I've made some extensive changes to the configuration box, implemented a gap skip option (similar behaviour to http://www.mediamonkey.com/forum/viewtopic.php?t=10051) for those files without LAME tag, added a tag preference order, and am working on writing APEv2 tags.

I won't do a release until APEv2 tag writing is at least working properly.

I think the plugin is almost complete, I'd like to hear any more feature requests etc.

Thanks for all support biggrin.gif
Go to the top of the page
+Quote Post
gameplaya15143
post Aug 8 2006, 01:09
Post #78





Group: Members
Posts: 484
Joined: 8-January 06
From: Earth
Member No.: 26978



remember that crashing problem? I haven't got the latest version, but it was never mentioned that the crashing thing was fixed...

It seems to crash if there is a sync error at the very beginning of an MP3, in_mad 1.14 plays it just fine.

I'll get right on those feature requests as soon as I test out the latest version wink.gif

But one for starters:
Option to 'display live average bitrate' to display the bitrate like in_mpg123 does for vbr files.
Maybe some more info about the MP3 that is playing, like if it has gapless tags and such. (i havent seen the latest version yet, so if that's already there, awsome!)


--------------------
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune
Go to the top of the page
+Quote Post
MoSPDude
post Aug 8 2006, 09:42
Post #79





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Ah right, do you have a test file that can reproduce the problem by any chance? If 1.14 plays it fine, it'll be related to the new tag features - probably the XING/LAME reader. To help me check that, can you please try it with madplay 0.15.2b. I doubt its to do with libid3tag - or rather I hope not!

I'll get a release up later today with APEv2 tag writing. At the moment, it shows what tags are present, but no more information on the LAME tag. The live average bitrate option, I think, is already there, but you need to disable "show average bitrate" to show the bitrate live as its decoded.
Go to the top of the page
+Quote Post
odyssey
post Aug 8 2006, 09:48
Post #80





Group: Members
Posts: 2296
Joined: 18-May 03
From: Denmark
Member No.: 6695



QUOTE (MoSPDude @ Aug 8 2006, 01:45) *
I think the plugin is almost complete, I'd like to hear any more feature requests etc.

I think i have a small problem with the Advanced Title Formatting, it seems that I cannot use %artist% and %title% tags for mp3 files anymore. However, the TPE1 and TIT2 tags work fine, so I could just use these and may be a suitable option if it's possible to use $if2($if2(A,B),B)... ?


--------------------
Can't wait for a HD-AAC encoder :P
Go to the top of the page
+Quote Post
MoSPDude
post Aug 8 2006, 18:00
Post #81





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Ok, I've done some more bug fixing. A new release is out. I hope I've fixed the advanced title formatting problem, and I've made some changes to the XING/LAME reading that was causing some files to falsely detect a LAME tag and screwing up.

Please can you test the 'gap removal' feature, and the APEv2 tag writing, and post your experiences.

Please update ASAP to this new version.

Thanks, smile.gif

EDIT: I left debug messages in again, please re-download if neccessary.

This post has been edited by MoSPDude: Aug 8 2006, 18:09
Go to the top of the page
+Quote Post
odyssey
post Aug 8 2006, 18:21
Post #82





Group: Members
Posts: 2296
Joined: 18-May 03
From: Denmark
Member No.: 6695



QUOTE (MoSPDude @ Aug 8 2006, 19:00) *
I hope I've fixed the advanced title formatting problem

Seems to work for me biggrin.gif i'm only left with the dreaded | character which Helium leaves in the field.... Seems that ATF don't have a replace function crying.gif

I appreciate you work really! It's cool finally to make efficient use of the ID3v2 field-set, and a great decoder too tongue.gif


--------------------
Can't wait for a HD-AAC encoder :P
Go to the top of the page
+Quote Post
bladecgn
post Aug 9 2006, 08:17
Post #83





Group: Members
Posts: 12
Joined: 12-June 06
From: Cologne/Germany
Member No.: 31765



Hi Craig... I installed MiniLyrics yesterday (cool program) and included lyrics tags in some mp3s. On some of those Winamp crashes now. No crash if I use in_mp3.

If you want me to send you a sample file, please let me know.
Go to the top of the page
+Quote Post
MoSPDude
post Aug 9 2006, 20:23
Post #84





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



QUOTE (bladecgn @ Aug 9 2006, 08:17) *
Hi Craig... I installed MiniLyrics yesterday (cool program) and included lyrics tags in some mp3s. On some of those Winamp crashes now. No crash if I use in_mp3.

If you want me to send you a sample file, please let me know.


If you could provide a sample that'd be a great help! I'm now just cleaning up areas I'd left messy code.
Go to the top of the page
+Quote Post
MoSPDude
post Aug 9 2006, 22:15
Post #85





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



I've uploaded a version that should work with long ID3v2 fields, it'll truncate them in the editor viewer though. This should fix the lyrics problem. I'm cleaning up some areas still.

Thanks for help smile.gif
Go to the top of the page
+Quote Post
MoSPDude
post Aug 11 2006, 07:32
Post #86





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Ok, after another look, I've fixed a problem with long APEv2 fields, again truncating them, NOW the lyrics problem should be fixed. An update will be available later, special thanks to bladecgn for helping me on that one.

Any idea on what kind of extra information can be included in the statisitcs info box for currently playing file?

Thanks to all smile.gif
Go to the top of the page
+Quote Post
MedO
post Aug 11 2006, 10:00
Post #87





Group: Members
Posts: 341
Joined: 24-August 05
Member No.: 24095



QUOTE (MoSPDude @ Aug 11 2006, 08:32) *
Ok, after another look, I've fixed a problem with long APEv2 fields, again truncating them, NOW the lyrics problem should be fixed. An update will be available later, special thanks to bladecgn for helping me on that one.

Any idea on what kind of extra information can be included in the statisitcs info box for currently playing file?

Thanks to all smile.gif


Applied gain would be nice.
Go to the top of the page
+Quote Post
gameplaya15143
post Aug 11 2006, 20:53
Post #88





Group: Members
Posts: 484
Joined: 8-January 06
From: Earth
Member No.: 26978



QUOTE (MoSPDude @ Aug 11 2006, 02:32) *
Any idea on what kind of extra information can be included in the statisitcs info box for currently playing file?

Total MS frames, IS frames, stereo frames, mono frames.

Indicator that gapless playback is possible on that particular file, and maybe some info like padding etc.


...I'll get around to downloading a new version one of these days dry.gif


--------------------
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune
Go to the top of the page
+Quote Post
MoSPDude
post Aug 11 2006, 22:06
Post #89





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Slight delay on the update, I don't want to leave half-finished code in.

@MedO, The applied gain level is shown on the Stats page in the Output box.

I'm adding a LAME tag info box (didn't feel the need for a page as it shouldn't really be edited), and will move some of the stats boxes to show the pie chart and an actual frame detail count at gameplaya15143 request.

My time on this project is becoming a bit tighter with work. gameplaya15143, does the last update (download from usual place) still crash on some of your files? could you PM me if it does. Thank you very much for help and support.

This post has been edited by MoSPDude: Aug 11 2006, 22:21
Go to the top of the page
+Quote Post
MoSPDude
post Aug 11 2006, 23:36
Post #90





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Another update has been uploaded, download from the main usual link http://www.zen23652.zen.co.uk/in_mad.zip .

The "More" button on the stats page is mainly a placeholder at the moment. I'm going to work on adding more detail to it. As mention before, time is becoming tighter but I'm still working on it - just a bit more slowly.

Thanks again to all those who are using it and bug finding smile.gif
Go to the top of the page
+Quote Post
MedO
post Aug 12 2006, 01:10
Post #91





Group: Members
Posts: 341
Joined: 24-August 05
Member No.: 24095



QUOTE (MoSPDude @ Aug 11 2006, 23:06) *
@MedO, The applied gain level is shown on the Stats page in the Output box.


Ah, sorry, there was a bit of confusion on my side, because of a small problem (bug?)
If I set the Replaygain option to "Audiophile" or "Radio", everything behaves as I would expect. However, there is also the option "Standard" I can't make anything of. If I enable it without "clipping prevention", no gain seems to be applied. If "clipping prevention" is on, there is a gain on some files, but I don't know where the value comes from. unsure.gif

Also, something is amiss with the save function in the file info box. Using it (from the Id3v1-tab, not sure with other tabs) causes random crashes. Also, when I add a field to the Id3v2-tag, hit "save" and then click on the id3v1-tab, the id3v2-tab is still shown, the only thing that changes is a blinking cursor where the Artist textbox in the id3v1-tab is. Well, just try it out, maybe you can see for yourself.
Go to the top of the page
+Quote Post
gameplaya15143
post Aug 12 2006, 05:42
Post #92





Group: Members
Posts: 484
Joined: 8-January 06
From: Earth
Member No.: 26978



MoSPDude wub.gif

I just downloaded the latest.. Absolutely amazing! and it doesn't crash anymore, reports the sync error and plays just fine.

I have 3 fun ideas:

1. Option to display live average bitrate (it can display the current frame size, but it would be nice to have it average those and display the average as say 117, 83, 175, etc. like how in_mpg123 displays the bitrate for vbr files)

2. Just a small bit of info on the main page "Gapless:" with a checkbox to indicate if gapless playback is possible with the file. (or is that implied when it says "with, LAME tags"?)

3. The ID3v2 tag editor is great, but for those of us that don't know what those tags are, how about somehow including the 'common' names for the 'artist' 'title' etc.? (same for the ape tags)

Just my thoughts smile.gif

Keep up the great work, and I'll try to crash it for you laugh.gif

edit: what about VBRI (fhg vbr header)?

edit2: how about a menu for common ape tags, like the id3v2 editor has?

This post has been edited by gameplaya15143: Aug 12 2006, 05:48


--------------------
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune
Go to the top of the page
+Quote Post
bladecgn
post Aug 12 2006, 05:47
Post #93





Group: Members
Posts: 12
Joined: 12-June 06
From: Cologne/Germany
Member No.: 31765



First off, thank you MoSPDude for correcting the lyrics bug. Everything's working fine now.

Quote from the replaygain website:
----
"Radio" Replay Gain adjustment

This will make all the tracks sound equally loud (as they do on the radio, hence the name!). If the ReplayGain is calculated on a track-by-track basis (i.e. an individual ReplayGain calculation is carried out for each track), this will be the result. This is something that ReplayGain does very well. Take a listen.
"Audiophile" Replay Gain adjustment

The problem with the "Radio" setting is that tracks which should be quiet will be brought up to the level of all the rest. For casual listening, or in a noisy background, this can be a good thing. For serious listening, it would be a nuisance. You don't want a solo flute track blasting at the same loudness as Iron Maiden!

To solve this problem, the "Audiophile"
setting represents the ideal listening gain for each track. ReplayGain can have a good guess at this too, by reading the entire CD, and calculating a single gain adjustment for the whole disc. This works because quiet tracks then stay quiter than the rest, since the gain won't be changed for each track. It still solves the basic problem (annoying, unwanted level differences between discs) because quiet or loud discs are still adjusted overall - so the pop CD that's 20 dB louder than the classical CD will be brought into line.
----

I think the designations "Radio" and "audiophile" are misleading, as you could think quality is affected by the setting but only volume level is. I'd rather be calling it "track gain" and "album gain".

This post has been edited by bladecgn: Aug 12 2006, 07:33
Go to the top of the page
+Quote Post
MoSPDude
post Aug 12 2006, 09:49
Post #94





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Yeah, the thought had crossed my mind to call it "Radio / Track" and "Audiophile / Album" as the vorbis decoder does. The standard setting I thought of calling "0 dB" - it disables the gain only. Basically, the gain you see when set to Standard comes from the clipping prevention ( 20 log( 1 / peak_value ) ) where peak_value is specified on the replaygain specs as full range at 1.
Shall I change the options then to None, Track and Album so as to make them clearer?

@gameplaya15143, I see, rather a running average display than a current frame rate display. I'll look into that. The gapless playback is implied when it specifies LAME tag, though again I will make it clearer, and your definately right about the ID3v2 editor needing the descriptions - also thinking of making the APEv2 field box a combo-dropdown so know what is generally available.

@MedO, I'll have a look into that one. I have a feeling I know whats causing it.

Thanks for all comments, keep up the good testing work biggrin.gif

This post has been edited by MoSPDude: Aug 12 2006, 10:42
Go to the top of the page
+Quote Post
gameplaya15143
post Aug 12 2006, 20:20
Post #95





Group: Members
Posts: 484
Joined: 8-January 06
From: Earth
Member No.: 26978



Did a feature get lost? I thought that previously there was an option to set the preamp for files without replaygain, now there is only the preamp for files with replaygain.

I found quite an annoyance yesterday involving mp3s that have no tags. I have it set to display the filename (which worked with the last version I used). Now when it plays a tagless mp3, it displays the title - song from either the last song played (be it mp3, ogg, etc. it doesn't matter) or some other song that is visible on the playlist at the time. It does this for any tagless mp3 in the playlist, even if it's not being played.

Just ran into another problem just now.
Song transition from mp3 to ogg, when the ogg starts playing I get nothing but white noise. If I disable 'remove gaps' the problem goes away. It only seems to occur with waveout using prebuffer on track change (outds is uneffected). The file causing this most likely has some errors at the end of the file.

And another... Tag editor causes winamp to crash when the song is not playing. Crashes on all tag types. blink.gif
I noticed that even after I hit stop, then view file info, the stats tab is still there. IIRC it wasn't in in_mad 1.14. Is it possible that things aren't being reset when they should be?
edit: Crash occurs when the song is played, then stoped, then tags edited. It doesn't crash if the song hasn't been played and stopped.

Using winamp 2.95 by the way.

This post has been edited by gameplaya15143: Aug 12 2006, 20:22


--------------------
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune
Go to the top of the page
+Quote Post
MoSPDude
post Aug 13 2006, 00:06
Post #96





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



I haven't properly got round to adding the preamp gain for files without RG yet. I promise I'll do it as soon as I can. tongue.gif

Hopefully, I can say that all your above problems have been cured if you download new release from the usual place. If you could please check, test and confirm.

I don't know what I'd do if hadn't got you guys to help me test this thing! Your help is very much appreciated, and thanks for bearing with me while I fix these problems. smile.gif
Go to the top of the page
+Quote Post
MoSPDude
post Aug 13 2006, 12:10
Post #97





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



I've fixed some more problems relating to the ReplayGain options and implemented a preamp option when no RG tag is found, as well as a 83dB reference level option as a -6.0dB preamp option.

I've added descriptive text to the ID3v2 editor, and a combobox for APE value names. I've change the VBR average display to show a running playback average at gameplaya15143 request.

I'm not too sure about implementing the VBRI header info. It doesn't seem too well supported in general, and I can't seem to find consistent details on it, other than possibly borrowing in_mpg123 implementation.

My next task currently is to display more information on the LAME tag.

Download from the usual, http://www.zen23652.zen.co.uk/in_mad.zip .
Go to the top of the page
+Quote Post
bladecgn
post Aug 13 2006, 13:17
Post #98





Group: Members
Posts: 12
Joined: 12-June 06
From: Cologne/Germany
Member No.: 31765



Hi... got another idea:

In the Preferences, you can select the order in which Winamp uses the tags to disply filenames.

It would be nice that if you open the file info box, automatically the tab opens up that ist selected first in the preferences, i.e. if ID3v1 is selected in the preferences, ID3v1 Tab is displayed automatically when you open the file info box.

Hope I made myself clear here... smile.gif
Go to the top of the page
+Quote Post
MoSPDude
post Aug 13 2006, 15:18
Post #99





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Another update, I've fixed ID3 to APE tag reading and made the change suggested by bladecgn with a slight difference. The opening page order is the same as specified in configuration. If no matching tag, then it'll open the General page.

Download from the usual place.
Go to the top of the page
+Quote Post
MoSPDude
post Aug 14 2006, 23:05
Post #100





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



For the next update, I've added streaming title support, made changes to how streams are detected and finished the LAME tag info box. I'm going to add a streaming info box, then I'll upload it.

Please bear with me, my time is a bit short.

Cheers biggrin.gif
Go to the top of the page
+Quote Post

15 Pages V  « < 2 3 4 5 6 > » 
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 21st September 2014 - 20:45