IPB

Welcome Guest ( Log In | Register )

15 Pages V   1 2 3 > »   
Reply to this topicStart new topic
Updated in_mad Winamp MAD MP3 input plugin
MoSPDude
post Jul 24 2006, 14:51
Post #1





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Hi, i've just finished updating the Winamp MAD input plugin 0.14.1b with,
* libmad 0.15.1b
* libid3tag 0.15.1b
* zlib 1.23
* Gaussian dither and noise shaping routines from SSRC 1.30
* Working ID3v2 editor
* APEv2 editor
* LAME gapless playback support
* Non-LAME tagged gap skip/removal feature
* ReplayGain support
* Winamp 5 advanced formatting support
* Shoutcast streaming title support

I'd like some other people to try it, and possible fix any remaining bugs etc. that I've probably missed.
I've included source code, it was compiled in Dev-C++ using the MinGW tools. Thanks for any and all feedback in advance.

*** The LATEST bugfixed DLL can be download from http://www.zen23652.zen.co.uk/in_mad.zip ***

This post has been edited by MoSPDude: Aug 22 2006, 14:31
Go to the top of the page
+Quote Post
Garf
post Jul 24 2006, 14:57
Post #2


Server Admin


Group: Admin
Posts: 4884
Joined: 24-September 01
Member No.: 13



QUOTE (MoSPDude @ Jul 24 2006, 15:51) *
* Gaussian dither and noise shaping routines from SSRC 1.30


What's the point of gaussian dither? In which circumstances would it have any advantages over triangular dither?
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 15:08
Post #3





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Perhaps so, I might make it so you can choose between rectangular, triangular or gaussian.

It turns out in AB listening tests, that most my family prefer no dither or noise shaping on the output at all.
Thats why there is an option to turn off dither and noise shaping.
Go to the top of the page
+Quote Post
Garf
post Jul 24 2006, 15:24
Post #4


Server Admin


Group: Admin
Posts: 4884
Joined: 24-September 01
Member No.: 13



It's extremely interesting they can hear a difference at all. (Is it statistically significant?)

AFAIK, this has so far only been accomplished under extreme circumstances.
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 15:37
Post #5





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



I thought it odd too, though I did agree - without the extra processing, the sound was clearer.

It was being pumped from winamp at 44.1kHz 24bit, via kernel streaming output plugin, digitally to a Marantz surround sound receiver in Source Direct stereo mode, to Eltax front speakers with mounted super tweeters.

Perhaps it has something to do with 'noiseamp' setting from SSRC, its fixed to 0.18 . Is that too much?

Thanks,
Craig
Go to the top of the page
+Quote Post
adamjk
post Jul 24 2006, 18:00
Post #6





Group: Members
Posts: 113
Joined: 30-September 01
Member No.: 116



So, at first I should compile it? Thank you very much!
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 18:44
Post #7





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



There is a ready compiled DLL in there called "in_mad.dll" - place that in your Winamp plugins folder.

It shouldn't depend on anything other than windows C runtime libraries, that you'd more than likely already have.

The source code was provided so anyone can see and improve on it as needed.
Go to the top of the page
+Quote Post
amano
post Jul 24 2006, 19:41
Post #8





Group: Members
Posts: 483
Joined: 1-December 02
Member No.: 3949



Is there media library support now?
Go to the top of the page
+Quote Post
adamjk
post Jul 24 2006, 19:53
Post #9





Group: Members
Posts: 113
Joined: 30-September 01
Member No.: 116



QUOTE (MoSPDude @ Jul 24 2006, 18:44) *
There is a ready compiled DLL in there called "in_mad.dll" - place that in your Winamp plugins folder.

It shouldn't depend on anything other than windows C runtime libraries, that you'd more than likely already have.

The source code was provided so anyone can see and improve on it as needed.

Sorry, obviously my mistake. The only one explanation is temperature, only 36 Celsius! I will try it!
Go to the top of the page
+Quote Post
MedO
post Jul 24 2006, 20:38
Post #10





Group: Members
Posts: 341
Joined: 24-August 05
Member No.: 24095



All running, but opening the file info box crashes winamp and then half my system with some files. I use Winamp 5.21, Windows XP home on a Celeron M 1400.
Here's a short file where this happens.
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 21:15
Post #11





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Will try and track it down, initial tests point to a libid3tag problem.
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 21:43
Post #12





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



In the test file, do you know what the ID3v2 tag frames are supposed to contain? The reason it was crashing is the frame id says to expect text - but it only contains garbage. It was a problem in my routine blindly expecting an entry in a string list.

The fixed in_mad.dll and updated in_mad.c is below,

http://www.zen23652.zen.co.uk/in_mad.2.zip
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 22:00
Post #13





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Media library support will be in the next build hopefully.

I might also get round to setting up a holding website.

Craig
Go to the top of the page
+Quote Post
MoSPDude
post Jul 24 2006, 22:52
Post #14





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



I've added media library support, its probably not very good but its working.

Download from,
http://www.zen23652.zen.co.uk/in_mad.3.zip

(file updated again at 23:03 BST - I'd managed to put a non-working copy in zip earlier)

This post has been edited by MoSPDude: Jul 24 2006, 23:52
Go to the top of the page
+Quote Post
MedO
post Jul 24 2006, 23:42
Post #15





Group: Members
Posts: 341
Joined: 24-August 05
Member No.: 24095



QUOTE (MoSPDude @ Jul 24 2006, 22:43) *
In the test file, do you know what the ID3v2 tag frames are supposed to contain? The reason it was crashing is the frame id says to expect text - but it only contains garbage. It was a problem in my routine blindly expecting an entry in a string list.

The fixed in_mad.dll and updated in_mad.c is below,

http://www.zen23652.zen.co.uk/in_mad.2.zip


The problematic files were music from a game (Poke646) so I don't know how they were created or what the metadata should be. The crash happened with all those files so I guess the encoder used was buggy. Thanks for fixing. cool.gif
Go to the top of the page
+Quote Post
niktheblak
post Jul 25 2006, 08:01
Post #16





Group: Members (Donating)
Posts: 302
Joined: 3-October 01
From: Finland
Member No.: 188



Holy dead decoder resurrection, Batman!

How many years it has been since the last MAD version, three? Now people can once more start claiming how MAD makes natural instruments sound more organic compared to Winamp decoder and mpg123!
Go to the top of the page
+Quote Post
odyssey
post Jul 25 2006, 09:08
Post #17





Group: Members
Posts: 2296
Joined: 18-May 03
From: Denmark
Member No.: 6695



Wow, I LOVE the way you show the original tagfield-names. Can these be implemented in the Title Formatting pleeeeeaaase? biggrin.gif crying.gif

Edit: Oh crap, it doesn't read recursive tags (from Helium). Only shows TXXX: #Helium Featured Artist. Can this be fixed in any way? I'd really like being able to format the title using my Helium tags

This post has been edited by odyssey: Jul 25 2006, 11:25


--------------------
Can't wait for a HD-AAC encoder :P
Go to the top of the page
+Quote Post
MoSPDude
post Jul 25 2006, 22:18
Post #18





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



Making the ID3v2 editor friendly is on the to-do list. I left it pretty much as the (disabled) one from 0.14.1b.

As for Helium tags, I'll have a look into it for you.

I've been fixing some minor problems with tags and libid3tag, such as not reading comments properly.

The latest dll will always be available from,
http://www.zen23652.zen.co.uk/in_mad.zip

I've not included source updates in the above, I'm planning to move and reorganise it all.

This post has been edited by MoSPDude: Jul 25 2006, 22:21
Go to the top of the page
+Quote Post
odyssey
post Jul 26 2006, 08:12
Post #19





Group: Members
Posts: 2296
Joined: 18-May 03
From: Denmark
Member No.: 6695



QUOTE (MoSPDude @ Jul 25 2006, 22:18) *
I've been fixing some minor problems with tags and libid3tag, such as not reading comments properly.

Yes, I think it's called comments the way they implement tags. Thanks biggrin.gif How about Title Formatting?

I like being able to see and edit *ALL* tags, and the real field-names, so don't make it too user friendly tongue.gif


--------------------
Can't wait for a HD-AAC encoder :P
Go to the top of the page
+Quote Post
john33
post Jul 26 2006, 08:37
Post #20


xcLame and OggDropXPd Developer


Group: Developer
Posts: 3760
Joined: 30-September 01
From: Bracknell, UK
Member No.: 111



@MoSPDude, we'd be happy to host this at Rarewares when you think it's ready, unless you prefer to host it yourself, of course. smile.gif


--------------------
John
----------------------------------------------------------------
My compiles and utilities are at http://www.rarewares.org/
Go to the top of the page
+Quote Post
MoSPDude
post Jul 26 2006, 09:11
Post #21





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



QUOTE (john33 @ Jul 26 2006, 08:37) *
@MoSPDude, we'd be happy to host this at Rarewares when you think it's ready, unless you prefer to host it yourself, of course. smile.gif


That'd be great, I don't think its too far off being ready. I've rearranged the source to make it more understandable when adding/upgrading sections, and fixed a few other things in the process, plus stripped the DLL properly down to size (thought it was set too, but wasn't).

I'm going away for the next 4-5 days, and won't get chance to work on it so I'll update http://www.zen23652.zen.co.uk/in_mad.zip with the rearranged source and smaller DLL a bit later.
Go to the top of the page
+Quote Post
john33
post Jul 26 2006, 09:40
Post #22


xcLame and OggDropXPd Developer


Group: Developer
Posts: 3760
Joined: 30-September 01
From: Bracknell, UK
Member No.: 111



QUOTE (MoSPDude @ Jul 26 2006, 09:11) *
That'd be great, I don't think its too far off being ready. I've rearranged the source to make it more understandable when adding/upgrading sections, and fixed a few other things in the process, plus stripped the DLL properly down to size (thought it was set too, but wasn't).

I'm going away for the next 4-5 days, and won't get chance to work on it so I'll update http://www.zen23652.zen.co.uk/in_mad.zip with the rearranged source and smaller DLL a bit later.

I'm also just about to go away for about 7 days, so we can sort it out when we're both back. smile.gif (I'll be in the depths of Wales without any access to the Internet!!) Have a good trip.


--------------------
John
----------------------------------------------------------------
My compiles and utilities are at http://www.rarewares.org/
Go to the top of the page
+Quote Post
MoSPDude
post Jul 26 2006, 18:41
Post #23





Group: Members
Posts: 175
Joined: 24-July 06
From: Sheffield, UK
Member No.: 33249



This is going to be that last update for next 5 days, before I finish packing!

I've fixed a new fault, where ID3v2 tags weren't delete properly because the ID3v1 tags weren't read properly, due to changes I made to make it read comments frame.

I've added to the basic title formatting, the ability to show any (text) frame. An example is to add "%#COMM" to make it show the comments field. You have to disable Winamp 5 advanced title formatting to use the plugins own basic formatting.

Download from the link given in my previous post.

@john33, I've only just come back from Wales!
Go to the top of the page
+Quote Post
Mr_Rabid_Teddybe...
post Jul 26 2006, 21:59
Post #24





Group: Members
Posts: 1197
Joined: 3-September 03
From: Bergen, Norway
Member No.: 8667



Sorry I can't test this myself (I'm in the process of moving house, computer in cardboard box); but have the annoying internet stream hijacking behavior of the previous in_mad been fixed? (Like if you tried to play a vorbis internet stream in _mad hijacked it from in_vorbis and made Winamp hang, as in_mad obviously can't decode a vorbis stream...)


--------------------
"ONLY THOSE WHO ATTEMPT THE IMPOSSIBLE WILL ACHIEVE THE ABSURD"
- Oceania Association of Autonomous Astronauts
Go to the top of the page
+Quote Post
gameplaya15143
post Jul 26 2006, 23:47
Post #25





Group: Members
Posts: 484
Joined: 8-January 06
From: Earth
Member No.: 26978



QUOTE (Mr_Rabid_Teddybear @ Jul 26 2006, 16:59) *
in _mad hijacked it from in_vorbis and made Winamp hang, as in_mad obviously can't decode a vorbis stream...)
... that I'm wondering the same thing, does in_mad.dll still break streaming? dry.gif

If not, here's my feature request: leave unknown BS to in_mp3.dll (ie http;//somestream:8000, as this could also be an aacplus stream or just a website on some other port, etc.), but have it capture a proper* stream url (ie http;//somestream:8000/mountpoint.mp3) (this scenerio is doable with in_mpg123)

Any plans to add APEv2 tag support? replaygain? gapless playback?

I'm very happy to see it finally get updated for ID3v2 tags though, thanks and keep up the great work.

*Why nullsoft used a url that could be anything, I'll never understand. Oh well, icecast2 is better than shoutcast anyways.
[edit]can't read[/edit]

This post has been edited by gameplaya15143: Jul 26 2006, 23:49


--------------------
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune
Go to the top of the page
+Quote Post

15 Pages V   1 2 3 > » 
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 3rd September 2014 - 08:25