IPB

Welcome Guest ( Log In | Register )

2 Pages V  < 1 2  
Reply to this topicStart new topic
ACM / DirectShow for WavPack?, Any plans for either?
DAvenger
post Jul 6 2004, 18:35
Post #26





Group: Members
Posts: 252
Joined: 15-May 03
From: Bratislava, SK
Member No.: 6640



QUOTE (zZzZzZz @ Jul 6 2004, 07:20 PM)
You don't need to learn or understand unicode/UTF-8 to make your library not interfere with it. Just implement file I/O callback mechanisms instead of making your library take a char* filename. If you think that's problematic, provide alternate file open function that takes file path and uses its own standard implementation of the callback, just like libvorbis does. That's currently biggest issue with your code (as far as I've read into it) because making a non-broken DirectShow filter or foobar2000 component requires severe changes in your source, and not many people have time to do that (especially that your library may need updating later, so hacking would need to be re-applied). Implementing file I/O callback involves changes that are too big to for someone to just make them and send you a patch, since you should be the one who makes architectural/design decisions there.

Amen.


--------------------
Reklama na internete - http://www.consultone.sk
Go to the top of the page
+Quote Post
RadScorpion
post Jul 6 2004, 18:48
Post #27





Group: Developer
Posts: 36
Joined: 16-May 03
From: Slovakia
Member No.: 6655



QUOTE
That's currently biggest issue with your code (as far as I've read into it) because making a non-broken DirectShow filter or foobar2000 component requires severe changes in your source, and not many people have time to do that (especially that your library may need updating later, so hacking would need to be re-applied). Implementing file I/O callback involves changes that are too big to for someone to just make them and send you a patch, since you should be the one who makes architectural/design decisions there.
Roger. One version of the SDK used FILE * as data source.. another one HANDL. both used char * as input file name.

Monkey Audio had the best API I've ever faced. One virtual reader interface and one decoding interface to be fed with data by the reader. This (IMHO I'm no container expert) should make the decoder able to receive data either from a file, network or a container. Adding unicode support is just a matter of overriding the constructor.


--------------------
have the force, read the source
Go to the top of the page
+Quote Post
bryant
post Jul 6 2004, 19:02
Post #28


WavPack Developer


Group: Developer (Donating)
Posts: 1291
Joined: 3-January 02
From: San Francisco CA
Member No.: 900



QUOTE (zZzZzZz @ Jul 6 2004, 09:20 AM)
You don't need to learn or understand unicode/UTF-8 to make your library not interfere with it. Just implement file I/O callback mechanisms instead of making your library take a char* filename. If you think that's problematic, provide alternate file open function that takes file path and uses its own standard implementation of the callback, just like libvorbis does. That's currently biggest issue with your code (as far as I've read into it) because making a non-broken DirectShow filter or foobar2000 component requires severe changes in your source, and not many people have time to do that (especially that your library may need updating later, so hacking would need to be re-applied). Implementing file I/O callback involves changes that are too big to for someone to just make them and send you a patch, since you should be the one who makes architectural/design decisions there.

Thanks, Peter. My current thinking is to have a new decoder open function that accepts two reader instances, one for the the main file and one for the correction file (which would be NULL if the application couldn't find it or can't be bothered). Not perfectly transparent, but much more usable. The encoder library interface was implemented this way.
Go to the top of the page
+Quote Post

2 Pages V  < 1 2
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 22nd August 2014 - 00:12