Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: buggy recompiled wsh panel mod (Read 2632 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

buggy recompiled wsh panel mod

Hi,

has someone successfully recompiled the last version 1.5.6 of WSH Panel mod?

So far I can compile it to run my scripts, but there is still a bug where the "Configuration Window" doesn't show up when you right click -> configure... or call the window.showConfigure() command. As opposed to that the "Properties Window" works fine.
Debugger tells me that the "DoModal" function of CDialogConf in wsh_panel_window::show_configure_popup returns -1.

I guess it might have something to do with scintilla, but no idea why.

Using visual studio 2010
atl files come with visual studio
wtl 7.5 (build 5333) (tried other versions no difference there)
scintilla 3.1.0 - for scintilla I have included the source and headers of the subfolders "include, src, lexlib, lexers, win32" into an empty project. Configured as a Static library with unicode and following preprocessor directives "WIN32, _DEBUG, _LIB, STATIC_BUILD, SCI_LEXER".
Also applied the column ui hacks mentioned by the original developer here

any ideas?

buggy recompiled wsh panel mod

Reply #1
Do you use the official source code for Scintilla? Do you have foo_wave_seekbar installed in the foobar2000 setup you use for testing?

I noticed that WSH panel mod uses a modified Scintilla version where the name of the window class is changed to "WshScintilla". If you use the official Scintilla version you may get window class name conflicts with the Scintilla copy used by foo_wave_seekbar.

buggy recompiled wsh panel mod

Reply #2
I'm using the official version from sourceforge and no foo_wave_seekbar. Just before I started this topic I created the project from scratch again with a fresh foobar installation 1.3.5 in portable mode so probably no conflicting components there.

buggy recompiled wsh panel mod

Reply #3
In this case the issue is probably that the WshScintilla window class from the dialog template cannot be found. I suggest you modify the window class name in your copy of Scintilla.

buggy recompiled wsh panel mod

Reply #4
Thanks! That worked perfectly and much faster than I expected it to.
For anyone interested just replace the two occurrences of "\"Scintilla\"" with "\"WshScintilla\"" in ScintillaWin.cxx