IPB

Welcome Guest ( Log In | Register )

12 Pages V   1 2 3 > »   
Reply to this topicStart new topic
Lyrics Grabber Feedback & Discussion, Proper place for Feedback & Discussion for foo_lyricsgrabber
T.P Wang
post Apr 22 2008, 08:15
Post #1





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



foo_lyricsgrabber is a component which allow users to download lyrics from specified lyrics provider.
Current supported
  • lyricwiki.org
  • lyricsplugin.com
Instructions
In context menu, Find "Lyrics Grabber", Choose a provider to download lyrics for tracks just selected. Or config properites by choosing "Configuration".


Requirements
foobar2000 0.9.5 or later


Changlog
CODE

0.2.6.2 Beta
FIX: Crash while decoding html entities that are at the end of the html content

0.2.6.1 Beta
FIX: Addtion spaces at the begining of a line
FIX: Results from LyricsPlugin always shows "<found>" even they are empty
FIX: "Configruation" grayed out after used once

0.2.6 Beta
ADD: New provider for lyricsplugin.com
CHG: Minor cleanups

0.2.5 Beta
FIX: Lyric could not get from lyricwiki.org due to case mismatch

0.2.4 Beta
ADD: New option for skipping updating file whose tag already exists
FIX: Cannot parse lyrics in multi chapter
FIX: Some lyrics cannot be parsed due to incorrect regular expression


0.2.3 Beta
FIX: Quick fix for lyric parsing

0.2.2 Beta

FIX: Quick fix for new lyricwiki.org site

0.2.1 Beta
FIX: Crashes when there is special character

0.2.0 Beta
ADD: In preview window, press "DELETE" key to remove selected items
ADD: Configruation window.
ADD: Lyric tag field name setting
ADD: Proxy setting (http, socks4, socks5)
FIX: Improved handling for lyric with sub-titles
FIX: Improved html tags & entities decoder
CHG: Various internal changes

0.1.6 Preview
FIX: LYRICS tag didn't have correct newline characters
FIX: LYRICS tag wirtten even if no lyrics found(null tag)
CHG: Some UI improvements

0.1.5 Preview
ADD: GUI for preview lyrics
FIX: Some glitches while updating tags

0.1.0 Preview
initial release



License
Released under MIT License

Credits
Thanks kanak for introducing lyricwiki

libcurl - Copyright © 1998 - 2008, Daniel Stenberg
DEELX Regular Expression Engine - Copyright 2006 © RegExLab.com, 史寿伟 (sswater shi)




Download here


This post has been edited by T.P Wang: Dec 24 2008, 13:29
Go to the top of the page
+Quote Post
Spirit_of_the_oc...
post Apr 22 2008, 12:06
Post #2





Group: Members
Posts: 583
Joined: 12-September 06
Member No.: 35092



As far as I can see it works via Context menu. It adds a button named "Functions" but by clicking it nothing happens. Is this intended? I am asking because this is a preview.

For me the important thing would be to have a preview of which lyrics are added. There was a component which had this feature.

This post has been edited by Spirit_of_the_ocean: Apr 22 2008, 12:11
Go to the top of the page
+Quote Post
T.P Wang
post Apr 22 2008, 12:33
Post #3





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



@Spirit_of_the_ocean:
GUI interface is working in progress.
It shouldn't be "Functions" in context menu, the default path for current version is Lyrics Grabber -> Lyricwiki, since there's only on provider now.

Once you've click that provider, a window will show progress, and then ask you to confirm the tag writting.
Go to the top of the page
+Quote Post
Spirit_of_the_oc...
post Apr 22 2008, 20:31
Post #4





Group: Members
Posts: 583
Joined: 12-September 06
Member No.: 35092



Sorry. In the menu toolbar a button named "Functions" is appearing. This appeared with the instalation of your plugin.
Go to the top of the page
+Quote Post
thuan
post Apr 22 2008, 20:55
Post #5





Group: Members
Posts: 964
Joined: 10-June 06
Member No.: 31716



Do you have foo_func then? It did that to me when I used it.
Go to the top of the page
+Quote Post
Spirit_of_the_oc...
post Apr 22 2008, 21:06
Post #6





Group: Members
Posts: 583
Joined: 12-September 06
Member No.: 35092



Oh you are right. blink.gif Sorry my mistake. sad.gif

This post has been edited by Spirit_of_the_ocean: Apr 22 2008, 21:06
Go to the top of the page
+Quote Post
q-stankovic
post Apr 23 2008, 15:20
Post #7





Group: Members
Posts: 1740
Joined: 28-May 06
From: Düsseldorf
Member No.: 31251



Very nice!! I am eager to follow the development - hope you will keep it clean and simple.


--------------------
german support forum: www.foobar-users.de / user: qwert73
Go to the top of the page
+Quote Post
pirlouy
post Apr 23 2008, 16:10
Post #8


troll / multiple accounts


Group: Banned
Posts: 98
Joined: 22-June 05
Member No.: 22890



What the best way to display LYRICS tag ? "Lyrics Show Panel" I guess, and it already has a grabber.
So this new plugin is nice, it works flawlessly but it lacks a simple plugin to display (long) tag.

By the way, is it a good thing to add all these data in a tag ? Is it not better to have lyrics in a file instead ?
Go to the top of the page
+Quote Post
T.P Wang
post Apr 23 2008, 18:40
Post #9





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



0.1.5 Preview is released.

QUOTE
Very nice!! I am eager to follow the development - hope you will keep it clean and simple.

Thank you, certinly I'll continue developing this component and try my best to make it clean and simple smile.gif

QUOTE
By the way, is it a good thing to add all these data in a tag ? Is it not better to have lyrics in a file instead ?

I think if we want to keep it simple and clean, store lyrics in tag is a good choice, but may not be the best choice for everyone.

This component is aimed to provide a "universal" lyrics grabber, easy to use for downloading without any more clicks.
Go to the top of the page
+Quote Post
T.P Wang
post Apr 24 2008, 04:10
Post #10





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



0.1.6 Preview is out, with some quick fixes. Note that this component is still under unstable stage. Use it with caution.
Go to the top of the page
+Quote Post
zachastrife
post Apr 24 2008, 08:56
Post #11





Group: Members
Posts: 144
Joined: 27-March 05
Member No.: 20990



I first tried this plugin on a track from the second CD of Dream Theater's Six Degrees of Inner Turbulence and was confused when I got the lyrics for the first song all the time.
Then I looked at LyricWiki and was rembered that this CD is named on the tracklist as 1 song =P
http://lyricwiki.org/Dream_Theater:Six_Deg...nner_Turbulence

(I am not saying this is a great problem, as this probably only applies to some DT tracks..., just thought I'd notify you of it).
Go to the top of the page
+Quote Post
T.P Wang
post Apr 24 2008, 18:19
Post #12





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



QUOTE
(I am not saying this is a great problem, as this probably only applies to some DT tracks..., just thought I'd notify you of it).


I'll consider that in the next version, thanks for reporting.

This post has been edited by T.P Wang: Apr 24 2008, 18:20
Go to the top of the page
+Quote Post
zachastrife
post Apr 24 2008, 19:24
Post #13





Group: Members
Posts: 144
Joined: 27-March 05
Member No.: 20990



QUOTE (T.P Wang @ Apr 24 2008, 18:19) *
QUOTE

(I am not saying this is a great problem, as this probably only applies to some DT tracks..., just thought I'd notify you of it).


I'll consider that in the next version, thanks for reporting.

Nice =)
A greater problem I just found though is tracks like DT's (again) The Glass Prison with "sub-titles",
as seen here:
http://lyricwiki.org/Dream_Theater:The_Glass_Prison

Your plugin again only finds the lyrics to the first part.
And this case is probably more frequent than the previous case so if you need to choose a behaviour, saving all the lyrics on the page is probably the best choice.

This post has been edited by zachastrife: Apr 24 2008, 19:25
Go to the top of the page
+Quote Post
q-stankovic
post Apr 25 2008, 16:17
Post #14





Group: Members
Posts: 1740
Joined: 28-May 06
From: Düsseldorf
Member No.: 31251



QUOTE (T.P Wang @ Apr 23 2008, 18:40) *
QUOTE
By the way, is it a good thing to add all these data in a tag ? Is it not better to have lyrics in a file instead ?

I think if we want to keep it simple and clean, store lyrics in tag is a good choice, but may not be the best choice for everyone.


For me the right place for storing lyrics is the file but i also can understand the need for storing them as text-files. If people are content with the same folder as track file the configuration would not bloat the preferences as a simple pattern like "%artist%-%title%" written in a textfield would be enough.

T.P Wang, can you give us the choice to write the lyrics in the "Unsynced Lyrics" frame?


--------------------
german support forum: www.foobar-users.de / user: qwert73
Go to the top of the page
+Quote Post
abchk
post Apr 26 2008, 09:12
Post #15





Group: Members
Posts: 24
Joined: 2-August 05
Member No.: 23646



Will it support custom_info db?

This post has been edited by abchk: Apr 26 2008, 16:47
Go to the top of the page
+Quote Post
q-stankovic
post Apr 26 2008, 22:01
Post #16





Group: Members
Posts: 1740
Joined: 28-May 06
From: Düsseldorf
Member No.: 31251



What is the advantage of using custom_info db?


--------------------
german support forum: www.foobar-users.de / user: qwert73
Go to the top of the page
+Quote Post
T.P Wang
post Apr 27 2008, 05:59
Post #17





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



QUOTE
And this case is probably more frequent than the previous case so if you need to choose a behaviour, saving all the lyrics on the page is probably the best choice.

Yes, I'll add some more code check for the toc title and then extract lyrics according to the toc title. It won't be easy for all these done tongue.gif


QUOTE
Will it support custom_info db?

No, since development of custom_info stopped for a long time, and the metadb_display_hook API is deprecated, custom_info will sooner or later be a "broken" component, thus I won't support custom_info in the future.


QUOTE
For me the right place for storing lyrics is the file but i also can understand the need for storing them as text-files

Hmm, I consider these needs. I'll add that feature later.


QUOTE
can you give us the choice to write the lyrics in the "Unsynced Lyrics" frame?

Yes, I'm working on the configruation of Lyrics Grabber and such.
Go to the top of the page
+Quote Post
T.P Wang
post Apr 28 2008, 17:24
Post #18





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



0.2.0 Beta released happy.gif
Go to the top of the page
+Quote Post
cartman(2vd)
post Apr 28 2008, 17:47
Post #19





Group: Members
Posts: 240
Joined: 10-August 06
Member No.: 33888



QUOTE (T.P Wang @ Apr 28 2008, 17:24) *
0.2.0 Beta released happy.gif


when i go in configurations and click provider/options/website internet explorer seems to be hardcoded as browser. not a big deal for me but would be nice if you could grab default browser from HKEY_CLASSES_ROOT\HTTP\shell\open\
Go to the top of the page
+Quote Post
T.P Wang
post Apr 28 2008, 18:14
Post #20





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



QUOTE
when i go in configurations and click provider/options/website internet explorer seems to be hardcoded as browser. not a big deal for me but would be nice if you could grab default browser from HKEY_CLASSES_ROOT\HTTP\shell\open\


Hmm, yes, so I've re-uploaded with that "quick fix" .
Go to the top of the page
+Quote Post
lyh
post Apr 28 2008, 20:13
Post #21





Group: Members
Posts: 8
Joined: 3-August 07
Member No.: 45869



many lyrics can't find,but in the web if I search ,I can find many lyrics.
It can't find if the tags are not complete?

This post has been edited by lyh: Apr 28 2008, 20:14
Go to the top of the page
+Quote Post
T.P Wang
post Apr 29 2008, 09:42
Post #22





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



@lyh:
It's highly depend on your TITLE and ARTIST tag.
It's not easy to support fuzzy matching for ARTIST and TITLE.
Go to the top of the page
+Quote Post
q-stankovic
post May 1 2008, 11:56
Post #23





Group: Members
Posts: 1740
Joined: 28-May 06
From: Düsseldorf
Member No.: 31251



QUOTE (T.P Wang @ Apr 29 2008, 09:42) *
It's not easy to support fuzzy matching for ARTIST and TITLE.


Would it be easier to look for ARTIST, ALBUM and TRACKNUMBER if lyrics are not found - so many times the lookup fails because the titles from file and from lyricwiki.org are a little bit different. (f.e. missing accents and so on)

This post has been edited by q-stankovic: May 1 2008, 11:59


--------------------
german support forum: www.foobar-users.de / user: qwert73
Go to the top of the page
+Quote Post
Yong H
post May 3 2008, 15:18
Post #24





Group: Members
Posts: 2
Joined: 3-May 08
Member No.: 53245



Hi ,very good pugins,but I have a problem,when it auto download from internet and output the *.lyr to my hard drive, the *.lyr 's name is different from the *.mp3.for example the song's name is (01. Candy Shop.mp3) but the lyr's name is (Madonna - Candy Shop.lrc) ,it's different .If I put these together to my MP3 player, it can't play the lyr. thanks.
Go to the top of the page
+Quote Post
T.P Wang
post May 3 2008, 16:23
Post #25





Group: Developer
Posts: 486
Joined: 8-June 07
From: Chengdu
Member No.: 44175



QUOTE (q-stankovic @ May 1 2008, 18:56) *
Would it be easier to look for ARTIST, ALBUM and TRACKNUMBER if lyrics are not found - so many times the lookup fails because the titles from file and from lyricwiki.org are a little bit different. (f.e. missing accents and so on)

Yes, I'll consider to implement that sooner after finishing scripting support and some UI improvements.


QUOTE (Yong H @ May 3 2008, 22:18) *
...when it auto download from internet and output the *.lyr to my hard drive ...

blink.gif
Have I added support for saving lyric in a file, or may be you've mistaken some softeares called "Lyrics Grabber"...

This post has been edited by T.P Wang: May 3 2008, 16:24
Go to the top of the page
+Quote Post

12 Pages V   1 2 3 > » 
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 28th July 2014 - 14:21