Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Lyrics Grabber Feedback & Discussion (Read 254735 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Lyrics Grabber Feedback & Discussion

Reply #75
What should happen ? Well, nothing in fact. Let me explain :
For me, the purpose of the (let's call it) %found lyrics% field (contents : either nothing or "Yes") is only to be able to find within foobar all songs which lyrics have been found and downloaded by Lyrics Grabber. It does not "associate" in any way the songs with the lyrics because that's not its purpose. So if the user decides to move or delete the lyrics files... well, that's his own problem : the %found lyrics% field will remain until he changes it within foobar.


Not very elegant - if such an option already forces user interaction to remove tags manually which was written once automatically so why not use the quicktagger instead to set manually such a tag- the effort is not very much higher to do so. Don't be angry, foorious, but i believe that such options in summary have potential for bloating the components preferences.

Lyrics Grabber Feedback & Discussion

Reply #76
I'm very thankful for T.P.Wang and I know he is one of the best active component developers. But he has admitted himself Lyrics Show Panel has some limitations (due to the previous developer).

And I definitively think the Lyrics Grabber component is well-thought. It's independent of UI, and I suppose some (future) UI Lyrics components could/will use an API to consider Lyrics Grabber. :-)

Lyrics Grabber Feedback & Discussion

Reply #77
Tiny changes to the 0.2.x branch:
0.2.6 Beta
* Add lyricsplugin.com as an alternative source
* Minor cleanups


Lyrics Grabber Feedback & Discussion

Reply #79
Quote
1. LyricsPlugin shows always <found> and adds empty <LYRICS>-Tags.

2. In context menu: Configuration is grayed out for some reason after used once.

Fixed in 0.2.6.1 Beta, Thanks for reporting.

Lyrics Grabber Feedback & Discussion

Reply #80

What should happen ? Well, nothing in fact. Let me explain :
For me, the purpose of the (let's call it) %found lyrics% field (contents : either nothing or "Yes") is only to be able to find within foobar all songs which lyrics have been found and downloaded by Lyrics Grabber. It does not "associate" in any way the songs with the lyrics because that's not its purpose. So if the user decides to move or delete the lyrics files... well, that's his own problem : the %found lyrics% field will remain until he changes it within foobar.


Not very elegant - if such an option already forces user interaction to remove tags manually which was written once automatically so why not use the quicktagger instead to set manually such a tag- the effort is not very much higher to do so. Don't be angry, foorious, but i believe that such options in summary have potential for bloating the components preferences.

Why not use a tagging component ? Well, because it's impossible when you have separate lyrics files instead of embedded lyrics : how would you know exactly which of all my 25.000 music files have separate lyrics files if you don't set up previously a tag that says "Yes, this file has a separate lyrics file" ? 

This option is useless for those like you who have embedded lyrics. But it's very useful (I'd even say mandatory) for those like me who want to have separate lyrics files (until the blessed day when foobar will be able to handle the "Excluded search fields" in its advanced prefs  ).

Thanks T.P Wang for having understood that, and I'm really looking forward for an implementation of this feature to really begin using Lyrics Grabber.


P.S. : if we want to keep prefs simple, then this option could be automatically enabled when the option "store lyrics in a separate file" is enabled. So in the prefs there would be only a single visible option "store lyrics in a separate file" and we would have this operatory mode :
- Embedded lyrics => lyrics stored in a %lyrics% tag AND NO %found lyrics% tag
- Separate lyrics files => lyrics stored in a separate file AND %found lyrics% tag automatically enabled
Would that be simple enough for you q-stankovic ?

Lyrics Grabber Feedback & Discussion

Reply #81
Hi T.P Wang, i think the download link is broken...
It is pointing to version v0.2.0 beta (Build: Apr 29 2008 00:10:12)!

Lyrics Grabber Feedback & Discussion

Reply #82
Quote
Hi T.P Wang, i think the download link is broken...
It is pointing to version v0.2.0 beta (Build: Apr 29 2008 00:10:12)!
f

Oh, Such A Mistake. My bad, please download it again

Lyrics Grabber Feedback & Discussion

Reply #83
Thanks, the download link it's working now.

But i spotted one problem:

LyricsPlugin shows always <found> even for instrumentals and adds this to tags:
[ Edit ] [ Search Google ] [ Configure ]

Lyrics Grabber Feedback & Discussion

Reply #84
Quote
LyricsPlugin shows always <found> even for instrumentals and adds this to tags:
[ Edit ] [ Search Google ] [ Configure ]

I won't fix that soon, however, if you find it really anonying, just use a Hex editor to open foo_lyricsgrabber.dll, then find:
Code: [Select]
[\r\n]*(.+?)

Then changed it like this (change one character '+' to '*'):
Code: [Select]
[\r\n]*(.*?)


Lyrics Grabber Feedback & Discussion

Reply #86
foobar crash during querying lyricsplugin:

artist: Bob Dylan
track title: Highway 61 Revisited
(maybe are numbers the problem)

(no crash report)

Confirmed, it's because that "&quot;" at the end of the lyric, will fixed in the next version.

Lyrics Grabber Feedback & Discussion

Reply #87
0.2.6.2 beta released, if you find any problem, please let me know.

Lyrics Grabber Feedback & Discussion

Reply #88
Why not use a tagging component ? Well, because it's impossible when you have separate lyrics files instead of embedded lyrics : how would you know exactly which of all my 25.000 music files have separate lyrics files if you don't set up previously a tag that says "Yes, this file has a separate lyrics file" ? 


I am a little bit confused - if your tracks already contain lyrics as textfiles you must download them again to get your desired tag. Or are you planning to download all the lyrics for all 25000 tracks with one click?

This option is useless for those like you who have embedded lyrics. But it's very useful (I'd even say mandatory) for those like me who want to have separate lyrics files (until the blessed day when foobar will be able to handle the "Excluded search fields" in its advanced prefs tongue.gif ).


As i said lyricsfiles are a reasonable feature i was thinking about watching them outside of foobar in explorer/editor. Your initial point is a missing feature inside of foobar wich induced you to request a totally other feature in an special component. Your request shows how a fullfilled request (textfiles) causes an avalanche of new feature and option requests although the origin problem could be solved without any user interaction or option.

P.S. : if we want to keep prefs simple, then this option could be automatically enabled when the option "store lyrics in a separate file" is enabled. So in the prefs there would be only a single visible option "store lyrics in a separate file" and we would have this operatory mode :
- Embedded lyrics => lyrics stored in a %lyrics% tag AND NO %found lyrics% tag
- Separate lyrics files => lyrics stored in a separate file AND %found lyrics% tag automatically enabled
Would that be simple enough for you q-stankovic ?


Please don't get me wrong: I understand why you would like to have that feature. I even believe that it can make sense to have opportunity thatt foobar tells us if a track is mapped to a cover picture or lyrics file - that could be done by foobar. But please see that in your suggestion for lyrics_grabber every option of that kind forces new users to bother with its full meaning and that in that sense just 2 or 3 feature/options more of that style will result in breaking the promise to develop a simple and clean component. But finally it is up to T.P. Wang to write what he think is senseful.

By the way: You are an user of DUI? How will you display your lyrics then?

 

Lyrics Grabber Feedback & Discussion

Reply #89
q-stankovic... I understand you are feeling concerned, but please understand one thing : what's a bit boring with you is that when you don't understand something, you are always requesting for more and more information and you are making endless posts simply because you don't know about (for example here) the details of my own config. So now I'm being forced to explain them to you, which will take me some time, and that is a bit boring because right now I'm focused on the implementation of that tiny new feature by T.P Wang, and not on going off-topic by explaining publicly the details of my config. I hope you undersand this.

So here are my answers, and I really hope you won't question me again  :

I am a little bit confused - if your tracks already contain lyrics as textfiles you must download them again to get your desired tag. Or are you planning to download all the lyrics for all 25000 tracks with one click?

None of my tracks (excepted some test files) have lyrics. I'm waiting for a component like Lyrics Grabber to be "mature enough" in order to start downloading them. And yes, I'm intending do do that in batch-mode if possible (although maybe not for 25.000 tracks at once).

As i said lyricsfiles are a reasonable feature i was thinking about watching them outside of foobar in explorer/editor. Your initial point is a missing feature inside of foobar wich induced you to request a totally other feature in an special component.

In no way I would want to watch separate lyrics files outside foobar ! All separate lyrics files will be accessed within foobar of course. How ? Read on.

I even believe that it can make sense to have opportunity thatt foobar tells us if a track is mapped to a cover picture or lyrics file

We're not talking about mapping here. We're only talking about saving a lyrics file and writing a tag that says "Yes, this track has a separate lyrics file". That's all, period.

By the way: You are an user of DUI? How will you display your lyrics then?

I have already said that in this topic. I'm using the excellent Lyric Show Panel (with Dockable Panels) and a keyboard shortcut to make it appear / disappear. It works great with DUI, no problems so far.

Lyrics Grabber Feedback & Discussion

Reply #90
what's a bit boring with you is that when you don't understand something ...


You don't understand something too!    F.E: With "As i said lyricsfiles are a reasonable feature i was thinking about watching them outside of foobar in explorer/editor. Your initial point is a missing feature inside of foobar wich induced you to request a totally other feature in an special component."
i just wanted to repeat again that the origin problem should be solved in foobar as the missing exclusion in searches are your initial and only point. With the first part of that quote i wanted to show some good reasons why textfiles can be useful. But if you have as only argument the search behaviour in foobar you indeed can't tell us any good reason to store lyrics inside textfiles instead of filetags. And just because of that search behaviour in foobar you are requesting an huge amount of features for another component: downloading textfiles, an option for storing a tag in files that lyrics are found, an option to define name of that tag and so on...

you are always requesting for more and more information and you are making endless posts simply because you don't know about (for example here) the details of my own config.


Hmm, i wasn't really interested in your configuration but in T.P. Wangs promise to develop a simple and clean component. Do you at least see why the requested way of implementing that desired feature could result in lost usabilty and simplicity for newbies - that is exactly the reason for me that i never used T.P. Wangs lyric_show_panel. Are you aware that if lyrics_grabber would have a feature to tag files automatically it then could be added to the list of problematic components like lyric_show_panel.

Based on your request let me ask a question: If you are more interested in the automatically settet tag than in the automatically setted tag would you be satisfied with following:

In the lyrics grabber window where you will have to press a button like "Store as textfile" and beside that button is a checkbox "tag files that lyrics are found" you will have to check - and nothing else: no options in preferences and no possibility to define the name of that tag.
You will have your desired feature and lyrics grabber wouldn't violate good behaviour with tagging files without user interaction.


By the way:
A direct question to Peter or Foosion: Can we expect that foobar somedays is changing its search behaviour in queries in that sense that multiline fields are excluded from simple search?

Edit: I took a look in the list of problematic and maybe an automatically setted tag like you, foorious, suggested wouldn't mean the same what brought lyric_show to the list - but however: it should be available as option in the download window and not anywhere in the preferences enabled by default.  Just my decent opinion how a good and usable component should be designed after i have seen so much horrible stuff in the last three or four years as components.

Lyrics Grabber Feedback & Discussion

Reply #91
why don't you PM each other and post the results?

Lyrics Grabber Feedback & Discussion

Reply #92
@2E7AH : maybe because despite a part of off-topic (which I regret) we are still discussing about Lyrics Grabber ?

Your initial point is a missing feature inside of foobar wich induced you to request a totally other feature in an special component."

No : this is not true, because even if the "exclude search fields" feature was added to foobar someday, there would still be people interested in storing lyrics as separate text files, just like there are other people interested in storing artwork as separate picture files. It's their choice and we all need to respect that without asking them for their own personal reasons.
So to sum it up : I would have requested this feature anyway, simply because it becomes very useful as soon as you have lyrics as separate text files.

Do you at least see why the requested way of implementing that desired feature could result in lost usabilty and simplicity for newbies

IMO "newbie" doesn't mean "complete dumb"    : a single checkbox like "Store lyrics as separate text files and enable a %lyrics found% tag" in a prefs window (especially if it's unchecked by default) would definitely not make Lyrics Grabber prefs any more complex for newbies. Come on, be realistic.

i never used T.P. Wangs lyric_show_panel

Well, you should. It has really improved over time and it has become a great component thanks to T.P's work.

would you be satisfied with following...

I would be satisfied with anything that allows me to do the 3 things I want in an easy way :
- grab LiricWiki lyrics
- store them as tags or as separate text files
- add a tag (%found lyrics% or any other name) only when lyrics are being found and stored in separate text files
(all these 3 things in batch-mode of course)
So I'm trying to remain focused on the features and not in the way of presenting them. That is T.P's decision after all.

A direct question to Peter or Foosion: Can we expect that foobar somedays is changing its search behaviour in queries in that sense that multiline fields are excluded from simple search?

I second that idea  , but it's off-topic here and like I've already said it would really deserve a separate "Feature request" topic to be more "visible". Don't you think so ?

Besides, why only multiline fields ? An excluded search fields list in Advanced Prefs would be so much better !!
Code: [Select]
Excluded search fields : LYRICS; UNSYNCED LYRICS; COMMENTS; LOG; (etc.)


Now can we please stick with this topic's subject and go on with Lyrics Grabber discussion ? Thank you. 

Lyrics Grabber Feedback & Discussion

Reply #93
T. P Wang

great component thank you!


Music is my first love.

Lyrics Grabber Feedback & Discussion

Reply #94
Quote
This option is useless for those like you who have embedded lyrics. But it's very useful (I'd even say mandatory) for those like me who want to have separate lyrics files (until the blessed day when foobar will be able to handle the "Excluded search fields" in its advanced prefs ).


Quote
So to sum it up : I would have requested this feature anyway, simply because it becomes very useful as soon as you have lyrics as separate text files.


 

Let's make it sticky!

Lyrics Grabber Feedback & Discussion

Reply #95
TP thx for creating such an easy plugin. I have one big wish for it. Can you make an option or commandlineswitch for silent tagging?

Search and tag found lyrics without userinterference that is? (like the silent replaygainscan/tag).

I am running it from commandline.

Lyrics Grabber Feedback & Discussion

Reply #96
(until the blessed day when foobar will be able to handle the "Excluded search fields" in its advanced prefs  )

Well, I think my prayers have been heard and that blessed day has come !  foobar 0.9.6.2 seems to have such ability (says the changelog, I haven't tried it myself). So embedding lyrics is now an acceptable option for me. 

Lyrics Grabber Feedback & Discussion

Reply #97
Quote
Can you make an option or commandlineswitch for silent tagging?

Search and tag found lyrics without userinterference that is?

Yes, I'll add it to the next new version.

Quote
Well, I think my prayers have been heard and that blessed day has come ! biggrin.gif foobar 0.9.6.2 seems to have such ability (says the changelog, I haven't tried it myself). So embedding lyrics is now an acceptable option for me. smile.gif

Bravo! So, I can release the new version earlier.

Lyrics Grabber Feedback & Discussion

Reply #98
Good news:

I've just tested(limited) the new, re-implemented Lyrics Grabber, I think It will be good for alpha test now.

Major changes:
  • Major internal changes, with one notabe feature
    • Provide SDK for making 3rd party lyric providers (see foo_grabber_python)
  • New tagger dialog (working in progress)
    • Context menu support
    • Shortcuts support
    • Sortable list view
    • Paint items whose lyrics not available with grey color
  • Configuration dialog (Minor chages only)
    • Add support for quite tagging mode
  • foo_grabber_python
    • Add python scripting support for lyrics grabber, as an extension
    • SINGLE THREAD ONLY, scripts will execute one by one (because it's not thread safe in python interpreter)
    • Based on python 2.5 Interpreter
    • Scripts Included:
      • DarkLyrics.com
If you are intrested in the alpha test, please contact me  (via P.M, or just reply to the topic)

EDIT: typo and scripts description in foo_grabber_python
EDIT: typo

Lyrics Grabber Feedback & Discussion

Reply #99
Current status:
  • Tiny fixes to DarkLyrics.py
  • Added AZLyrics.py
  • Fix to Lib/Html2Text.py: in order to get more reasonable result
  • Fix to Lib/Lucky.py: Changed User-Agent
If you have taked part in the alpha test, please go
http://code.google.com/p/lyricsgrabber/sou...grabber_python/
and Download these four files:
  • DarkLyrics.py
  • AZLyrics.py
  • Lib/Html2Text.py
  • Lib/Lucky.py
Copy and overwrite exsiting files in {your profile folder}/grabber_python

EDIT: typo