IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
Bug in WavPack 4.70.0, Segmentation Fault when executing wvgain with -n option & invalid
martin.steghoefe...
post Aug 12 2014, 13:58
Post #1





Group: Members
Posts: 3
Joined: 12-August 14
Member No.: 116953



Hi!

I couldn't find a bug tracker, so I'm posting the bug report here (as this is the "official" forum, I suppose the developers are reading this).

Version 4.70.0 of wvgain contains a bug that has been detected by the Mayhem software and has been reported to the Debian bug tracker:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=716478

The Mayhem test case can be generalized: The executable wvgain crashes with segmentation fault whenever given an invalid filename and the "-n" option. The reason is a call to WavpackCloseFile(..) on a NULL pointer as file handle, if the file couldn't be opened. I'm proposing the bug fix that I've already posted on the Debian bug tracker (URL given above).

Cheers,
Martin
Go to the top of the page
+Quote Post
martin.steghoefe...
post Aug 12 2014, 14:27
Post #2





Group: Members
Posts: 3
Joined: 12-August 14
Member No.: 116953



Link to the patch: https://bugs.debian.org/cgi-bin/bugreport.c...tt=1;bug=716478
Go to the top of the page
+Quote Post
bryant
post Aug 15 2014, 19:19
Post #3


WavPack Developer


Group: Developer (Donating)
Posts: 1297
Joined: 3-January 02
From: San Francisco CA
Member No.: 900



Hi Martin,

Thanks for the patch; I'll get it in right away! smile.gif

There actually is an issue tracker in the GitHub repo, but I don't think anyone has used it; I need to make it clearer that WavPack is now hosted there.

Cheers,
David
Go to the top of the page
+Quote Post
martin.steghoefe...
post Aug 31 2014, 13:15
Post #4





Group: Members
Posts: 3
Joined: 12-August 14
Member No.: 116953



Oh, if I had known that, I'd have sent a pull request directly... smile.gif
Go to the top of the page
+Quote Post
DARcode
post Oct 4 2014, 18:16
Post #5





Group: Members (Donating)
Posts: 682
Joined: 10-January 05
From: Italy
Member No.: 18968



Patched WvGain in the pipeline smile.gif ?


--------------------
WavPack 4.70.0 -b384hx6cmv/qaac 2.43 -V 100
Go to the top of the page
+Quote Post
bryant
post Dec 1 2014, 06:55
Post #6


WavPack Developer


Group: Developer (Donating)
Posts: 1297
Joined: 3-January 02
From: San Francisco CA
Member No.: 900



Patch has been applied in Git. Thanks again! smile.gif
Go to the top of the page
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 23rd December 2014 - 00:54