Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: WSH Panel Mod script discussion/help (Read 1399938 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

WSH Panel Mod script discussion/help

Reply #3825 –
^i think that would be better suited in it's own script. i'll post something with enough comments in to get you going later.

WSH Panel Mod script discussion/help

Reply #3826 –
All right, thanks...
Do you mean the browser buttons as well? I think they would be nice there on the top of the panel actually, as I want three versions of all buttons, and the lists already have the right "headlines": album/artist/track. The other ones would just be a bonus to have there.

WSH Panel Mod script discussion/help

Reply #3827 –
Quote from: sylla on
marc2003:I set it up like this now, realized I wanted the musicbrainz script as well


Can you please share this modified slimier artist script of yours??

WSH Panel Mod script discussion/help

Reply #3828 –
@sylla, hopefully this is enough to get you started...

https://dl.dropboxusercontent.com/u/2280132...ruary/sylla.txt

btw, in case you didn't know, my artreader and CD jewel case scripts already have options for launching album art downloader using the right click menu. they use the current artist/album as the search terms.

WSH Panel Mod script discussion/help

Reply #3829 –
marc2003: wow, thanks. very nice. And the jewel case is in your now playing as well, no I didn't know that. Really good being able to open the folder as well from there by doubleclicking  And the tooltip showing image size. My player will be perfect

Do you think I should share the code to people like samithaj who asks?

samithaj: Right now the script is too messy. And I don't know what marc2003 thinks about me sharing. I of course understand too little to be able to answer if something I changed doesn't work for somebody else, or want different buttons than I and so on.

WSH Panel Mod script discussion/help

Reply #3830 –
that script should be ok to share - so long as you're not changing anything that affects how often the script downloads fresh info. if you're just adding buttons, it should be fine.

WSH Panel Mod script discussion/help

Reply #3831 –
Ok, then I will share when I have worked on it a bit. You gave me this before, but just cosmetic and not about downloads, right:
function on_metadb_changed() {
    li.metadb_changed();
    li.items = Math.min(50, li.items); //edit the 20 if you want

Immediately realized some mistakes I had made before when I tried to get some other button scripts into the similar panel.

WSH Panel Mod script discussion/help

Reply #3832 –
@Falstaff - unfortunately JSPlaylist is still not fully stable for me:

Code: [Select]
WSH Panel Mod (JSPlaylist v1.2.1 by Br3tt aka Falstaff >> http://br3tt.deviantart.com): Microsoft JScript runtime error:
       'this.groups[...].collapsed' is null or not an object
       File: I:\foobar2000\wsh_br3tt\jsplaylist\js\WSHplaylist.js
       Line: 1796, Col: 9
       <source text only available at compile time>


It also does not like loading covers supplied by the foo_youtube plug-in: "clip thumbnails" - mostly they take ages to load and often don't load at all. For comparison es, el and sim-playlists and your coverflow view script are all fine - at least your coverflow loads rapidly without JSPlaylist installed. When JSPlaylist is loaded and spinning away trying to get the thumbnails and mostly failing it slows down loading by coverflow markedly. So it seems to be interfering with other wsh scripts.

WSH Panel Mod script discussion/help

Reply #3834 –
Quote from: WilB on
@Falstaff - unfortunately JSPlaylist is still not fully stable for me:

Code: [Select]
WSH Panel Mod (JSPlaylist v1.2.1 by Br3tt aka Falstaff >> http://br3tt.deviantart.com): Microsoft JScript runtime error:
       'this.groups[...].collapsed' is null or not an object
       File: I:\foobar2000\wsh_br3tt\jsplaylist\js\WSHplaylist.js
       Line: 1796, Col: 9
       <source text only available at compile time>


It also does not like loading covers supplied by the foo_youtube plug-in: "clip thumbnails" - mostly they take ages to load and often don't load at all. For comparison es, el and sim-playlists and your coverflow view script are all fine - at least your coverflow loads rapidly without JSPlaylist installed. When JSPlaylist is loaded and spinning away trying to get the thumbnails and mostly failing it slows down loading by coverflow markedly. So it seems to be interfering with other wsh scripts.


thanx for reporting, but could you explain me when this happen please ? are group inautocollapse mode or have you use the Collapse All action ? and what are you doinf when it happens, a double click on a collapsed group to expand it or whatelse ? thanks by advance to help to render it more stable about this collapse/expand feature.

WSH Panel Mod script discussion/help

Reply #3835 –
Quote from: WilB on
It also does not like loading covers supplied by the foo_youtube plug-in: "clip thumbnails" - mostly they take ages to load and often don't load at all. For comparison es, el and sim-playlists and your coverflow view script are all fine - at least your coverflow loads rapidly without JSPlaylist installed. When JSPlaylist is loaded and spinning away trying to get the thumbnails and mostly failing it slows down loading by coverflow markedly. So it seems to be interfering with other wsh scripts.


just tested on my DUI config that contains only a WSH Panel (JSPlaylist) and covers load perfectly with foo_youtube. What are the others WSH panels running in your config, 'cause what you discribe is a typical bad use of timer in WSH panels that may generate issues in others WSH panels.
*waits for feedback*

WSH Panel Mod script discussion/help

Reply #3836 –
I haven't touched any of the JSPlaylist settings - so they are all at default; I haven't used Collapse All action.

Issue seems to occur when multiple tracks are added to a playlist via the command line with add location...

A quick test show that putting the following on line 1796 of WSHplaylist.js stopped the crash:

if (!this.groups[grp_id]) return;

But as you understand your code better than me you may know a better way...

HTH

WSH Panel Mod script discussion/help

Reply #3837 –
Quote from: WilB on
I haven't touched any of the JSPlaylist settings - so they are all at default; I haven't used Collapse All action.

Issue seems to occur when multiple tracks are added to a playlist via the command line with add location...

A quick test show that putting the following on line 1796 of WSHplaylist.js stopped the crash:

if (!this.groups[grp_id]) return;

But as you understand your code better than me you may know a better way...

HTH


maybe fixed for next release (soon)

and what about my question about other WSH panel mod you are running and causing trouble in JSPlaylist cover loading ... ? just tested again JSP and WSH Coverflow panel and all is fine, a can't reproduce it but i'm sure it's due to another WSH panel mod, so i'm extremly curious to get your other WSH panel mod scripts you are running to find the guilty

capture

WSH Panel Mod script discussion/help

Reply #3838 –
Ok I can reproduce it with a very simple DUI set-up. In this the only wsh panel is your JSPlaylist.

The picture shows side by side results with JSPlaylist and esplaylist. Tracks were added with the YouTube Source - Search (Integrated) panel. I have now been writing this post for a few minutes and still no YouTube thumbnails have appeared. Playing various tracks did not help...


   

WSH Panel Mod script discussion/help

Reply #3839 –
@WilB

thank you, i will try to reproduce it by mimics this layout...

EDIT: done but i can't reproduce it, all works fine for me  could you zip your whole basic config to let me test is as it is for you, that may help me to reproduce it.

WSH Panel Mod script discussion/help

Reply #3840 –
i created that exact layout and it works for me??

)

WSH Panel Mod script discussion/help

Reply #3841 –
^same as Marc here as EDITED in previous post.

@WilB: could you send me a zip file with your config to let me test it ?

WSH Panel Mod script discussion/help

Reply #3842 –
The set up is quite vanilla. Further investigation, now that I have managed to get back on my main computer, shows that all is fine there - all images load pretty quickly. However if the self same portable set up is installed on the USB stick I was using earlier, then many of the youtube thumbnails still don't end up loading. So I guess its related to the slower speed of the USB 2 stick. Let me know if you still want the zip and where you want me to send it.
 

WSH Panel Mod script discussion/help

Reply #3843 –
A new version of the YouTube Track Manager script is available (v1.5). YouTube Track Manager is a database search companion to the foo_youtube plug-in. It features improved album management through addition of an interactive discography with similar and related artists. In addition to wsh_panel_mod 1.5.6+, the foo_youtube plug-in is required and then you can play the music in foobar2000 as well. Its free of adverts and you needn't watch the videos - since just audio-only can be streamed at up to 256 kbps AAC. Supports last.fm top albums, top tracks, top similar songs and MusicBrainz lists. Buttons to change type. Auto-generation of top 50 playlists. Auto-pick "radio" mode. Auto-track renaming. Optional integration with media library. Blacklist to avoid specific YouTube tracks. Download and full details here.

There have been a lot of changes, so please report if anything needs fixing.

WSH Panel Mod script discussion/help

Reply #3844 –
marc2003: I am trying to incorporate the buttons you gave me into the similar script. No problem with the buttons that paints the same for every lastfm_mode. (I made vars that change the function of them)

you told me to use "b.buttons.name.x =" in on_paint for panel size dependent buttons. Is it bad to just use b.update() there? You used that in your tutorial and it seems to work here as well?

Would you use if statements for the buttons that change depending on li.lastfm_mode? I am trying with that, but if I use your method in "on_size" I get messages that buttons don't exist if I am in another mode, and if I just use b.update() the buttons doesn't update when I change lastfm_mode...

Then I placed text here: I would want it to be clickable, and I also wonder how I could get the header...
Code: [Select]
function on_paint(gr) {
p.draw_background(gr);
p.right_text(gr,"("+header+")", gdi.Font("Segoe UI", 8,0), p.textcolour_hl, 80, -3, b.w, 24);

I tried with this:
Code: [Select]
if   (li.lastfm_mode == 0) {header = artist;}
else if   (li.lastfm_mode == 1) {header = album;}
else if   (li.lastfm_mode == 3) {header = "title";}

Both inside the b.update function and above it (of course defining artist and so on above it) but neither way gives correctly updated info to on_paint...

WSH Panel Mod script discussion/help

Reply #3845 –
Quote from: sylla on
you told me to use "b.buttons.name.x =" in on_paint for panel size dependent buttons. Is it bad to just use b.update() there? You used that in your tutorial and it seems to work here as well?


damn it, you just made me realise i fudged up some my customisation page. it's not too serious but there is a bit of bad practice there. i need to tidy it up.

as for your script, just bundle it up with all the images and i'll fix it. i'll add some comments like before because it's easier than trying to explain formally.

WSH Panel Mod script discussion/help

Reply #3846 –
Like this?
Saw you using dropbox but didn't use it myself before.

Sorry about the messy code, hope you understand what I am trying to do. I am trial and erroring mostly...

edit: https://www.dropbox.com/s/rmz7hcy6dd1akf0/t.zip?dl=0

WSH Panel Mod script discussion/help

Reply #3847 –
^i'll take a look at that later.

@falstaff, i've noticed your latest JSplaylist uses the UI colours for the settings panel now but i don't think you've tested it on columns UI?



with default UI, i notice even the dark colour schemes from the presets have white backgrounds for the text input box but this does not. also, there is no contrast colour on the column "list box".

here's .cfg file if you want to take a look: https://dl.dropboxusercontent.com/u/2280132...columns.dll.cfg

WSH Panel Mod script discussion/help

Reply #3848 –
Quote from: marc2003 on
^i'll take a look at that later.


Thanks. I'll upload a new version with the right buttons and so on soon so don't start before that

Ah, it's the same link. Now all buttons work the way they should and from what I've seen they get updated correctly all the time when I switch focus or lastfm_mode.
Only thing is the images don't get removed when I switch mode.
And then the other thing is the text, which I'd like to be clickable and updated the same way as the buttons. I get errors when I try to draw the text inside the b.update function...

WSH Panel Mod script discussion/help

Reply #3849 –
Quote from: marc2003 on
@falstaff, i've noticed your latest JSplaylist uses the UI colours for the settings panel now but i don't think you've tested it on columns UI?


arf, that's it 

done to quickly, will try to fix that tomorrow, thanx for reporting.

EDIT: but, you are using v1.2.2 ??? i've posted a v1.2.3 after your post and normally it's fixed ... btw still not tested under CUI for now